GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso: move sb_clk_output_48Mhz from acp to fch 

Move sb_clk_output_48Mhz out of acp. It should be called unconditionally.
We may have another device need this clock e.g. superio chip.

BUG=b:174121847
BRANCH=zork
TEST= build passed

Signed-off-by: Eric Lai <ericr_lai@compal.corp-partner.google.com>
Change-Id: I30ad6c60066f17cc83e7feb40675610f4853a022
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48722
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Eric Lai 2020-12-18 10:51:46 +08:00 committed by Felix Held
parent dd32e653cf
commit 3b648baf03
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/soc/amd/picasso/acp.c
View File

@ -46,9 +46,6 @@ static void init(struct device *dev)
/* Enable ACP_PME_EN and ACP_I2S_WAKE_EN for I2S_WAKE event */ /* Enable ACP_PME_EN and ACP_I2S_WAKE_EN for I2S_WAKE event */
acp_update32(bar, ACP_I2S_WAKE_EN, WAKE_EN_MASK, !!cfg->acp_i2s_wake_enable); acp_update32(bar, ACP_I2S_WAKE_EN, WAKE_EN_MASK, !!cfg->acp_i2s_wake_enable);
acp_update32(bar, ACP_PME_EN, PME_EN_MASK, !!cfg->acp_pme_enable); acp_update32(bar, ACP_PME_EN, PME_EN_MASK, !!cfg->acp_pme_enable);
if (cfg->acp_pin_cfg == I2S_PINS_I2S_TDM)
sb_clk_output_48Mhz(); /* Internal connection to I2S */
} }
static const char *acp_acpi_name(const struct device *dev) static const char *acp_acpi_name(const struct device *dev)

2
src/soc/amd/picasso/fch.c
View File

@ -237,6 +237,8 @@ void southbridge_init(void *chip_info)
al2ahb_clock_gate(); al2ahb_clock_gate();
gpp_clk_setup(); gpp_clk_setup();
sb_clk_output_48Mhz();
} }
void southbridge_final(void *chip_info) void southbridge_final(void *chip_info)