GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/zork: Fix active polarity of REPORT_EN pin in overridetree 

GPIO_144 is REPORT_EN pin for the touchscreen controller where 1 means
enable operation and 0 means stop operation. Override tree exposes
this pin as stop GPIO. Thus, it needs to be configured as active low
i.e. 0 = active (stop), 1 = inactive (enable report).

Change-Id: I349123655260349b78d2f75f846da0ce1dc966fc
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44911
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Furquan Shaikh 2020-08-28 12:24:22 -07:00
parent 000003ea1e
commit 3b72f64513
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/zork/variants/dalboz/overridetree.cb
View File

@ -86,7 +86,7 @@ chip soc/amd/picasso
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)"
register "generic.reset_delay_ms" = "120" register "generic.reset_delay_ms" = "120"
register "generic.reset_off_delay_ms" = "1" register "generic.reset_off_delay_ms" = "1"
register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)" register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)"
register "generic.stop_off_delay_ms" = "1" register "generic.stop_off_delay_ms" = "1"
register "generic.has_power_resource" = "1" register "generic.has_power_resource" = "1"
register "hid_desc_reg_offset" = "0x01" register "hid_desc_reg_offset" = "0x01"

2
src/mainboard/google/zork/variants/dirinboz/overridetree.cb
View File

@ -56,7 +56,7 @@ chip soc/amd/picasso
register "enable_delay_ms" = "1" register "enable_delay_ms" = "1"
register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)"
register "reset_delay_ms" = "20" register "reset_delay_ms" = "20"
register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)" register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)"
register "stop_off_delay_ms" = "1" register "stop_off_delay_ms" = "1"
register "has_power_resource" = "1" register "has_power_resource" = "1"
register "disable_gpio_export_in_crs" = "1" register "disable_gpio_export_in_crs" = "1"

2
src/mainboard/google/zork/variants/morphius/overridetree.cb
View File

@ -70,7 +70,7 @@ chip soc/amd/picasso
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)"
register "generic.reset_delay_ms" = "120" register "generic.reset_delay_ms" = "120"
register "generic.reset_off_delay_ms" = "1" register "generic.reset_off_delay_ms" = "1"
register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)" register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)"
register "generic.stop_off_delay_ms" = "1" register "generic.stop_off_delay_ms" = "1"
register "generic.has_power_resource" = "1" register "generic.has_power_resource" = "1"
register "generic.disable_gpio_export_in_crs" = "1" register "generic.disable_gpio_export_in_crs" = "1"

2
src/mainboard/google/zork/variants/vilboz/overridetree.cb
View File

@ -101,7 +101,7 @@ chip soc/amd/picasso
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)"
register "generic.reset_off_delay_ms" = "1" register "generic.reset_off_delay_ms" = "1"
register "generic.reset_delay_ms" = "120" register "generic.reset_delay_ms" = "120"
register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_144)" register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_144)"
register "generic.stop_off_delay_ms" = "1" register "generic.stop_off_delay_ms" = "1"
register "generic.has_power_resource" = "1" register "generic.has_power_resource" = "1"
register "hid_desc_reg_offset" = "0x01" register "hid_desc_reg_offset" = "0x01"