GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/xcompile: Print fatal error messages to stderr instead of stdout 

This uses die() which was previously unused.
Before this change an unhelpful error message was printed when make tried
to parse English text as if it was part of the makefile:
.xcompile:1: *** missing separator (did you mean TAB instead of 8 spaces?).  Stop.

After this change the first error message at least mentions that iasl is
missing:
ERROR: no iasl found
make: -print-libgcc-file-name: Command not found
make: -print-libgcc-file-name: Command not found
make: -print-libgcc-file-name: Command not found
/bin/sh: 0: Illegal option -
Makefile.inc:36: *** Please use the coreboot toolchain (or prove that your toolchain works).  Stop.

Change-Id: I79d5de5993e3828460130192df376daa55f32aa0
Signed-off-by: Daniele Forsi <dforsi@gmail.com>
Reviewed-on: http://review.coreboot.org/6272
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <gaumless@gmail.com>
This commit is contained in:
Daniele Forsi 2014-07-14 15:35:42 +02:00 committed by Patrick Georgi
parent be5340bad2
commit 3bb0b7230c
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
util/xcompile/xcompile
View File

@ -49,8 +49,7 @@ if [ "$(${XGCCPATH}/iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then
elif [ "$(iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then elif [ "$(iasl 2>/dev/null | grep -c ACPI)" -gt 0 ]; then
IASL=iasl IASL=iasl
else else
echo "no iasl found" die "no iasl found"
exit 1
fi fi
if program_exists gcc; then if program_exists gcc; then
@ -58,8 +57,7 @@ if program_exists gcc; then
elif program_exists cc; then elif program_exists cc; then
HOSTCC=cc HOSTCC=cc
else else
echo "no host compiler found" die "no host compiler found"
exit 1
fi fi
cat <<EOF cat <<EOF
@ -196,8 +194,7 @@ test_architecture() {
if type arch_config_$architecture > /dev/null; then if type arch_config_$architecture > /dev/null; then
arch_config_$architecture arch_config_$architecture
else else
echo "no architecture definition for $architecture" die "no architecture definition for $architecture"
exit 1
fi fi
# To override toolchain, define CROSS_COMPILE_$arch or CROSS_COMPILE as # To override toolchain, define CROSS_COMPILE_$arch or CROSS_COMPILE as