GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso: use SMBus speed in compilation unit 

The fixed bus speed of 400 kHz doesn't need to reside in a header file.
Just move the assumption into the code itself.

Change-Id: I8bb68607070d0daeae2ad3bcd79f49d5c20048fd
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38613
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Aaron Durbin 2020-01-28 10:58:13 -07:00
parent 178d644d62
commit 3bee7df954
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/picasso/include/soc/smbus.h
View File

@ -19,8 +19,6 @@
#include <stdint.h> #include <stdint.h>
#include <soc/iomap.h> #include <soc/iomap.h>
#define SMB_SPEED_400KHZ (66000000 / (400000 * 4))
/* /*
* Between 1-10 seconds, We should never timeout normally * Between 1-10 seconds, We should never timeout normally
* Longer than this is just painful when a timeout condition occurs. * Longer than this is just painful when a timeout condition occurs.

5
src/soc/amd/picasso/southbridge.c
View File

@ -253,8 +253,11 @@ void sb_read_mode(u32 mode)
static void fch_smbus_init(void) static void fch_smbus_init(void)
{ {
/* 400 kHz smbus speed. */
const uint8_t smbus_speed = (66000000 / (400000 * 4));
pm_write8(SMB_ASF_IO_BASE, SMB_BASE_ADDR >> 8); pm_write8(SMB_ASF_IO_BASE, SMB_BASE_ADDR >> 8);
smbus_write8(SMBTIMING, SMB_SPEED_400KHZ); smbus_write8(SMBTIMING, smbus_speed);
/* Clear all SMBUS status bits */ /* Clear all SMBUS status bits */
smbus_write8(SMBHSTSTAT, SMBHST_STAT_CLEAR); smbus_write8(SMBHSTSTAT, SMBHST_STAT_CLEAR);
smbus_write8(SMBSLVSTAT, SMBSLV_STAT_CLEAR); smbus_write8(SMBSLVSTAT, SMBSLV_STAT_CLEAR);