GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/poppy/variants/baseboard: Add gpio-keys ACPI node for PENH 

This change uses gpio_keys driver to add ACPI node for pen eject event.

BUG=b:74413116
TEST=Verified using evtest that pen eject event results in events as
     expected.

Change-Id: I6019d633f4337137bb9fbba770040cb5b30da773
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://review.coreboot.org/25147
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Nicolas Boichat 2018-03-14 15:46:15 +08:00 committed by Furquan Shaikh
parent 21df67ecd4
commit 3bfd734e6b
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/mainboard/google/poppy/variants/baseboard/devicetree.cb
View File

@ -318,6 +318,15 @@ chip soc/intel/skylake
register "hid_desc_reg_offset" = "0x1" register "hid_desc_reg_offset" = "0x1"
device i2c 0x9 on end device i2c 0x9 on end
end end
chip drivers/generic/gpio_keys
register "name" = ""PENH""
register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_D8)"
register "key.dev_name" = ""EJCT""
register "key.linux_code" = "SW_PEN_INSERTED"
register "key.linux_input_type" = "EV_SW"
register "key.label" = ""pen_eject""
device generic 0 on end
end
end # I2C #3 end # I2C #3
device pci 16.0 on end # Management Engine Interface 1 device pci 16.0 on end # Management Engine Interface 1
device pci 16.1 off end # Management Engine Interface 2 device pci 16.1 off end # Management Engine Interface 2

2
src/mainboard/google/poppy/variants/baseboard/gpio.c
View File

@ -177,7 +177,7 @@ static const struct pad_config gpio_table[] = {
/* D7 : ISH_I2C1_SDA ==> NC */ /* D7 : ISH_I2C1_SDA ==> NC */
PAD_CFG_NC(GPP_D7), PAD_CFG_NC(GPP_D7),
/* D8 : ISH_I2C1_SCL ==> PEN_EJECT_ODL -- for notification */ /* D8 : ISH_I2C1_SCL ==> PEN_EJECT_ODL -- for notification */
PAD_CFG_GPI(GPP_D8, 20K_PU, PLTRST), PAD_CFG_GPI_GPIO_DRIVER(GPP_D8, 20K_PU, DEEP),
/* D9 : ISH_SPI_CS# ==> HP_IRQ_GPIO */ /* D9 : ISH_SPI_CS# ==> HP_IRQ_GPIO */
PAD_CFG_GPI_GPIO_DRIVER(GPP_D9, NONE, PLTRST), PAD_CFG_GPI_GPIO_DRIVER(GPP_D9, NONE, PLTRST),
/* D10 : ISH_SPI_CLK ==> SPKR_RST_L */ /* D10 : ISH_SPI_CLK ==> SPKR_RST_L */