From 3c0350989d2569dc6973ebcfcacbf8acb40c1679 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 8 May 2023 20:00:07 +0200 Subject: [PATCH] mb/intel/glkrvp: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I817faab0438a35d2e8859342e7c2b2dbaa0afeeb Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/78129 Reviewed-by: Martin L Roth Tested-by: build bot (Jenkins) --- src/mainboard/intel/glkrvp/Kconfig | 4 ++++ src/mainboard/intel/glkrvp/Kconfig.name | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index c2584f31c7..5a1ae43e1e 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -13,6 +13,10 @@ config BOARD_INTEL_BASEBOARD_GLKRVP select DRIVERS_I2C_DA7219 select SOC_ESPI +config BOARD_INTEL_GLKRVP + select BOARD_INTEL_BASEBOARD_GLKRVP + select BASEBOARD_GLKRVP_LAPTOP + if BOARD_INTEL_BASEBOARD_GLKRVP config BASEBOARD_GLKRVP_LAPTOP diff --git a/src/mainboard/intel/glkrvp/Kconfig.name b/src/mainboard/intel/glkrvp/Kconfig.name index b0cfdc5fa2..0502c4c18c 100644 --- a/src/mainboard/intel/glkrvp/Kconfig.name +++ b/src/mainboard/intel/glkrvp/Kconfig.name @@ -1,4 +1,2 @@ config BOARD_INTEL_GLKRVP bool "Glkrvp" - select BOARD_INTEL_BASEBOARD_GLKRVP - select BASEBOARD_GLKRVP_LAPTOP