GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/deltaur: Make return values non-const 

Returning a const uint32_t doesn't do anything, and it conflicts with the
declaration of sku_id() in include/boardid.h.

Change-Id: I2719e5782c9977f8ca4ce8f1dd781f092aa73d64
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1428708
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44746
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jacob Garber 2020-08-24 18:33:40 -06:00 committed by Patrick Georgi
parent b126380b00
commit 3c16fe4fad
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/deltaur/variants/baseboard/sku.c
View File

@ -6,12 +6,12 @@
#include <smbios.h> #include <smbios.h>
#include <variant/variant.h> #include <variant/variant.h>
static const uint32_t get_sku_index(void) static uint32_t get_sku_index(void)
{ {
return ((!has_360_sensor_board()) | (wilco_ec_signed_fw() << 1)); return ((!has_360_sensor_board()) | (wilco_ec_signed_fw() << 1));
} }
const uint32_t sku_id(void) uint32_t sku_id(void)
{ {
return skus[get_sku_index()].id; return skus[get_sku_index()].id;
} }