GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/include/psp_efs: don't typedef struct 

Don't use a typedef for the embedded_firmware struct so that it's
clearer that this is a struct.

TEST=Timeless build for google/guybrush results in identical binary.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I97a02c350af57c8f58014aaf7dda8b4796905ff3
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58420
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Kangheui Won <khwon@chromium.org>
This commit is contained in:
Felix Held 2021-10-18 14:04:01 +02:00 committed by Felix Held
parent ad68b07d45
commit 3c1c90bf61
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/common/block/include/amdblocks/psp_efs.h
View File

@ -30,7 +30,7 @@ struct second_gen_efs { /* todo: expand for Server products */
} __attribute__((packed)); } __attribute__((packed));
/* Copied from coreboot/util/amdfwtool.h */ /* Copied from coreboot/util/amdfwtool.h */
typedef struct _embedded_firmware { struct embedded_firmware {
uint32_t signature; /* 0x55aa55aa */ uint32_t signature; /* 0x55aa55aa */
uint32_t imc_entry; uint32_t imc_entry;
uint32_t gec_entry; uint32_t gec_entry;
@ -60,7 +60,7 @@ typedef struct _embedded_firmware {
uint8_t reserved_4Ah; uint8_t reserved_4Ah;
uint8_t reserved_4Bh; uint8_t reserved_4Bh;
uint32_t reserved_4Ch; uint32_t reserved_4Ch;
} __attribute__((packed, aligned(16))) embedded_firmware; } __attribute__((packed, aligned(16)));
bool efs_is_valid(void); bool efs_is_valid(void);
bool read_efs_spi_settings(uint8_t *mode, uint8_t *speed); bool read_efs_spi_settings(uint8_t *mode, uint8_t *speed);

2
src/soc/amd/common/block/psp/psp_efs.c
View File

@ -6,7 +6,7 @@
#include <commonlib/region.h> #include <commonlib/region.h>
#include <types.h> #include <types.h>
static struct _embedded_firmware *efs; static struct embedded_firmware *efs;
bool efs_is_valid(void) bool efs_is_valid(void)
{ {