From 3c2305f162d24cf07fa6079bd20fd2839e5d672c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Tue, 2 Jul 2019 13:54:52 +0300 Subject: [PATCH] drivers/amd/agesa: Drop redundant stack allocation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The removed call was there to support case LATE_CBMEM_INIT=y, HAVE_ACPI_RESUME=y. Same stack space is already allocated with postcar_frame_init() call. Change-Id: I03a44bc3252f553b1769d362b2f442d3e6ab73f4 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/33956 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Mike Banon Reviewed-by: Angel Pons --- src/drivers/amd/agesa/oem_s3.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/drivers/amd/agesa/oem_s3.c b/src/drivers/amd/agesa/oem_s3.c index acd34b8edf..9514bcdf5e 100644 --- a/src/drivers/amd/agesa/oem_s3.c +++ b/src/drivers/amd/agesa/oem_s3.c @@ -18,7 +18,6 @@ #include #include #include -#include #include #include #include @@ -122,8 +121,6 @@ AGESA_STATUS OemS3Save(AMD_S3_PARAMS *dataBlock) u32 MTRRStorageSize = 0; uintptr_t pos, size; - romstage_ram_stack_base(HIGH_ROMSTAGE_STACK_SIZE, ROMSTAGE_STACK_CBMEM); - /* To be consumed in AmdInitResume. */ get_s3nv_data(S3DataTypeNonVolatile, &pos, &size); if (size && dataBlock->NvStorageSize)