GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso,stoneyridge/acpi: drop unneeded res2 FADT assignment 

The FADT data structure is zero-initialized in acpi_create_fadt which
then calls the SoC-specific acpi_fill_fadt function, therefore it's not
needed to assign 0 to the res2 FADT field in acpi_fill_fadt.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ifa69ae61bea82acf66e7210c4103ef48e36dbdd2
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73318
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2023-02-27 20:58:15 +01:00
parent a77bb32573
commit 3c74a5107d
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/soc/amd/picasso/acpi.c
View File

@ -89,7 +89,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
fadt->day_alrm = RTC_DATE_ALARM; fadt->day_alrm = RTC_DATE_ALARM;
fadt->mon_alrm = 0; fadt->mon_alrm = 0;
fadt->iapc_boot_arch = cfg->fadt_boot_arch; /* legacy free default */ fadt->iapc_boot_arch = cfg->fadt_boot_arch; /* legacy free default */
fadt->res2 = 0; /* reserved, MUST be 0 ACPI 3.0 */
fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-34 ACPI 6.3 spec */ fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-34 ACPI 6.3 spec */
ACPI_FADT_C1_SUPPORTED | ACPI_FADT_C1_SUPPORTED |
ACPI_FADT_S4_RTC_WAKE | ACPI_FADT_S4_RTC_WAKE |

1
src/soc/amd/stoneyridge/acpi.c
View File

@ -81,7 +81,6 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
fadt->day_alrm = RTC_DATE_ALARM; fadt->day_alrm = RTC_DATE_ALARM;
fadt->mon_alrm = 0; /* Not supported */ fadt->mon_alrm = 0; /* Not supported */
fadt->iapc_boot_arch = FADT_BOOT_ARCH; /* See table 5-10 */ fadt->iapc_boot_arch = FADT_BOOT_ARCH; /* See table 5-10 */
fadt->res2 = 0; /* reserved, MUST be 0 ACPI 3.0 */
fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-10 ACPI 3.0a spec */ fadt->flags |= ACPI_FADT_WBINVD | /* See table 5-10 ACPI 3.0a spec */
ACPI_FADT_C1_SUPPORTED | ACPI_FADT_C1_SUPPORTED |
ACPI_FADT_SLEEP_BUTTON | ACPI_FADT_SLEEP_BUTTON |