GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Documentation/gerrit: Update parts about WIP and draft commits 

Gerrit dropped the "draft" concept and replaced it with private commits
and work-in-progress commits, options that can be used independently
from each other.

Change-Id: I6abe267c2091c750fc234057be3a4e62adb59c4c
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://review.coreboot.org/c/30309
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Patrick Georgi 2018-12-19 11:39:39 +01:00
parent b6fe048910
commit 3c86293dc1
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Documentation/getting_started/gerrit_guidelines.md
View File

@ -159,15 +159,19 @@ this is by marking in the commit message that it’s not ready until X. The
commit message can be updated easily when it’s ready to be pushed. commit message can be updated easily when it’s ready to be pushed.
Examples of this are "WIP: title" or "[NEEDS_TEST]: title". Another way to Examples of this are "WIP: title" or "[NEEDS_TEST]: title". Another way to
mark the patch as not ready would be to give it a -1 or -2 review, but mark the patch as not ready would be to give it a -1 or -2 review, but
isn't as obvious as the commit message. These patches can also be pushed as isn't as obvious as the commit message. These patches can also be pushed with
drafts as shown in the next guideline. the wip flag:
git push origin HEAD:refs/for/master%wip
* When pushing patches that are not for submission, these should be marked * When pushing patches that are not for submission, these should be marked
as such. This can be done in the title ‘[DONOTSUBMIT]’, or can be pushed as as such. This can be done in the title ‘[DONOTSUBMIT]’, or can be pushed as
draft commits, so that only explicitly added reviewers will see them. These private changes, so that only explicitly added reviewers will see them. These
sorts of patches are frequently posted as ideas or RFCs for the community sorts of patches are frequently posted as ideas or RFCs for the community
to look at. To push a draft, use the command: to look at. To push a private change, use the command:
git push origin HEAD:refs/for/master%private,wip git push origin HEAD:refs/for/master%private
* Multiple push options can be combined:
git push origin HEAD:refs/for/master%private,wip,topic=experiment
* Respond to anyone who has taken the time to review your patches, even if * Respond to anyone who has taken the time to review your patches, even if
it's just to say that you disagree. While it may seem annoying to address a it's just to say that you disagree. While it may seem annoying to address a