GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge/raminit: Fix normalize_training 

Remove cross rank/cross channel dependency.
I guess this is a mistake that could lead to instabilities.

Tested on Lenovo T430 (Intel IvyBridge).

Change-Id: I899db907cd2d2197fd81eda4c4656fb1e570c18f
Signed-off-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-on: https://review.coreboot.org/17610
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
Tested-by: build bot (Jenkins)
This commit is contained in:
Patrick Rudolph 2016-11-25 16:00:01 +01:00 committed by Martin Roth
parent 7dee97454a
commit 3c8cb97ea7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/northbridge/intel/sandybridge/raminit_common.c
View File

@ -3023,10 +3023,11 @@ int discover_timC_write(ramctr_timing *ctrl)
void normalize_training(ramctr_timing * ctrl)
{
int channel, slotrank, lane;
int mat = 0;
int mat;
FOR_ALL_CHANNELS FOR_ALL_POPULATED_RANKS {
int delta;
mat = 0;
FOR_ALL_LANES mat =
max(ctrl->timings[channel][slotrank].lanes[lane].timA, mat);
printram("normalize %d, %d, %d: mat %d\n",