GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/picasso/soc_util: add comment on socket detection problems 

At least some Pollock engineering samples return FP5 socket type while
they are in fact FT5 socket type.

Change-Id: I06a19c19374532bfb367fc15c734707d8c7f65a3
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41796
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2020-05-27 23:25:38 +02:00 committed by Felix Held
parent 94c2f76616
commit 3c93b7e166
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/picasso/soc_util.c
View File

@ -12,6 +12,7 @@
#define SOCKET_TYPE_SHIFT 28 #define SOCKET_TYPE_SHIFT 28
#define SOCKET_TYPSE_MASK (0xf << SOCKET_TYPE_SHIFT) #define SOCKET_TYPSE_MASK (0xf << SOCKET_TYPE_SHIFT)
/* some Pollock engineering samples return the wrong socket type */
enum socket_type get_socket_type(void) enum socket_type get_socket_type(void)
{ {
uint32_t ebx = cpuid_ebx(0x80000001); uint32_t ebx = cpuid_ebx(0x80000001);
@ -132,6 +133,7 @@ enum silicon_type get_silicon_type(void)
return SILICON_UNKNOWN; return SILICON_UNKNOWN;
} }
/* some Pollock engineering samples return the wrong socket type and get detected as Dali */
enum soc_type get_soc_type(void) enum soc_type get_soc_type(void)
{ {
switch (get_socket_type()) { switch (get_socket_type()) {