GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/kukui: fix the issue of getting error panel_id 

Current get panel_id is over sku_id() >> 4, but sku_id is combined with
wfc_id/lcm_id/sku_id, so the panel_id value is wfc_id << 4 | lcm_id()
in fact. When wfc_id is not 0, the panel_id will be wrong. So only get
the low 4 bits for the panel_id.

BUG=b:183779755
BRANCH=kukui
TEST=emerge-kukui

Change-Id: I63e0c8a2719462a9b979afe52a27c78b9fc804e8
Signed-off-by: Tao Xia <xiatao5@huaqin.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51853
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
This commit is contained in:
xuxinxiong 2021-03-26 22:53:35 +08:00 committed by Patrick Georgi
parent f147051535
commit 3ced5287f2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/kukui/mainboard.c
View File

@ -124,7 +124,7 @@ struct panel_description *get_panel_from_cbfs(struct panel_description *desc)
static struct panel_description *get_active_panel(void)
{
/* TODO(hungte) Create a dedicated panel_id() in board_id.c */
int panel_id = sku_id() >> 4;
int panel_id = sku_id() >> 4 & 0x0F;
struct panel_description *panel = get_panel_description(panel_id);
if (!panel) {