soc/intel/tigerlake: Avoid NULL pointer dereference
Coverity detects dereferencing pointers that might be "NULL" when calling acpigen_write_scope and acpigen_write_device. Add sanity check for both of scope and name to prevent NULL pointer dereference. Found-by: Coverity CID 1429981 TEST=Built and boot up to kernel. Signed-off-by: John Zhao <john.zhao@intel.com> Change-Id: Iea3801585e8c294fb889a8137b534bb932696025 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42836 Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
parent
ff4ead052b
commit
3d6066eacc
|
@ -99,8 +99,13 @@ static void soc_pmc_read_resources(struct device *dev)
|
|||
|
||||
static void soc_pmc_fill_ssdt(const struct device *dev)
|
||||
{
|
||||
acpigen_write_scope(acpi_device_scope(dev));
|
||||
acpigen_write_device(acpi_device_name(dev));
|
||||
const char *scope = acpi_device_scope(dev);
|
||||
const char *name = acpi_device_name(dev);
|
||||
if (!scope || !name)
|
||||
return;
|
||||
|
||||
acpigen_write_scope(scope);
|
||||
acpigen_write_device(name);
|
||||
|
||||
acpigen_write_name_string("_HID", PMC_HID);
|
||||
acpigen_write_name_string("_DDN", "Intel(R) Tiger Lake IPC Controller");
|
||||
|
|
Loading…
Reference in New Issue