GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/tgl: Unhide PMC, IOM ACPI devices from OS 

These were hidden because no Windows drivers existed, but now that
they do, the ACPI devices need to be visible in order for the
drivers to properly attach.

TEST=build google/drobit, boot Windows, verify Windows drivers
correctly attach to PCM/IOM devices.

Change-Id: I1520a71e318674baa234fc6a2126d1d17933d983
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/74829
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: CoolStar <coolstarorganization@gmail.com>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
This commit is contained in:
Matt DeVillier 2022-11-29 13:00:31 -06:00 committed by Matt DeVillier
parent c259d71928
commit 3d85d6b292
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/soc/intel/tigerlake/acpi/tcss.asl
View File

@ -331,8 +331,7 @@ Scope (\_SB.PCI0)
Name (_CRS, ResourceTemplate () { Name (_CRS, ResourceTemplate () {
Memory32Fixed (ReadWrite, IOM_BASE_ADDRESS, IOM_BASE_SIZE) Memory32Fixed (ReadWrite, IOM_BASE_ADDRESS, IOM_BASE_SIZE)
}) })
/* Hide the device so that Windows does not complain on missing driver */ Name (_STA, 0xF)
Name (_STA, 0xB)
} }
/* /*

3
src/soc/intel/tigerlake/pmc.c
View File

@ -107,8 +107,7 @@ static void soc_pmc_fill_ssdt(const struct device *dev)
acpigen_write_name_string("_HID", PMC_HID); acpigen_write_name_string("_HID", PMC_HID);
acpigen_write_name_string("_DDN", "Intel(R) Tiger Lake IPC Controller"); acpigen_write_name_string("_DDN", "Intel(R) Tiger Lake IPC Controller");
/* Hide the device so that Windows does not complain on missing driver */ acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);
acpigen_write_STA(ACPI_STATUS_DEVICE_HIDDEN_ON);
/* /*
* Part of the PCH's reserved 32 MB MMIO range (0xFC800000 - 0xFE7FFFFF). * Part of the PCH's reserved 32 MB MMIO range (0xFC800000 - 0xFE7FFFFF).