GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel: Obsolete mmap_region_granularity() 

Change-Id: I471598d3ce61b70e35adba3bd983f5d823ba3816
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34696
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Kyösti Mälkki 2019-07-25 08:49:03 +03:00
parent e29b80429f
commit 3dddf4fb41
6 changed files with 0 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Documentation/Intel/SoC/soc.html
View File

@ -148,7 +148,6 @@ mv build/coreboot.rom.new build/coreboot.rom
<li>Edit the src/soc/&lt;Vendor&gt;/&lt;Chip Family&gt;/memmap.c file <li>Edit the src/soc/&lt;Vendor&gt;/&lt;Chip Family&gt;/memmap.c file
<ol type="A"> <ol type="A">
<li>Add the fsp/memmap.h include file</li> <li>Add the fsp/memmap.h include file</li>
<li>Add the mmap_region_granularity routine</li>
</ol> </ol>
</li> </li>
<li>Add the necessary .h files to define the necessary values and structures</li> <li>Add the necessary .h files to define the necessary values and structures</li>

7
src/drivers/intel/fsp1_1/include/fsp/memmap.h
View File

@ -18,13 +18,6 @@
#include <types.h> #include <types.h>
/*
* mmap_region_granularity must to return a size which is a positive non-zero
* integer multiple of the SMM size when SMM is in use. When not using SMM,
* this value should be set to 8 MiB.
*/
size_t mmap_region_granularity(void);
/* Fills in the arguments for the entire SMM region covered by chipset /* Fills in the arguments for the entire SMM region covered by chipset
* protections. e.g. TSEG. */ * protections. e.g. TSEG. */
void smm_region(void **start, size_t *size); void smm_region(void **start, size_t *size);

7
src/drivers/intel/fsp2_0/include/fsp/memmap.h
View File

@ -18,13 +18,6 @@
#include <types.h> #include <types.h>
/*
* mmap_region_granularity must to return a size which is a positive non-zero
* integer multiple of the SMM size when SMM is in use. When not using SMM,
* this value should be set to 8 MiB.
*/
size_t mmap_region_granularity(void);
/* Fills in the arguments for the entire SMM region covered by chipset /* Fills in the arguments for the entire SMM region covered by chipset
* protections. e.g. TSEG. */ * protections. e.g. TSEG. */
void smm_region(void **start, size_t *size); void smm_region(void **start, size_t *size);

7
src/soc/intel/braswell/memmap.c
View File

@ -34,13 +34,6 @@ void smm_region(void **start, size_t *size)
*size = smm_region_size(); *size = smm_region_size();
} }
size_t mmap_region_granularity(void)
{
/* Align to TSEG size when SMM is in use, and 8MiB by default */
return CONFIG(HAVE_SMI_HANDLER) ? smm_region_size()
: 8 << 20;
}
/* /*
* Subregions within SMM * Subregions within SMM
* +-------------------------+ BUNIT_SMRRH * +-------------------------+ BUNIT_SMRRH

7
src/soc/intel/denverton_ns/include/soc/smm.h
View File

@ -24,13 +24,6 @@ struct smm_relocation_attrs {
uint32_t smrr_mask; uint32_t smrr_mask;
}; };
/*
* mmap_region_granularity must to return a size which is a positive non-zero
* integer multiple of the SMM size when SMM is in use. When not using SMM,
* this value should be set to 8 MiB.
*/
size_t mmap_region_granularity(void);
/* Fills in the arguments for the entire SMM region covered by chipset /* Fills in the arguments for the entire SMM region covered by chipset
* protections. e.g. TSEG. */ * protections. e.g. TSEG. */
void smm_region(void **start, size_t *size); void smm_region(void **start, size_t *size);

11
src/soc/intel/skylake/memmap.c
View File

@ -30,17 +30,6 @@
#include "chip.h" #include "chip.h"
size_t mmap_region_granularity(void)
{
if (CONFIG(HAVE_SMI_HANDLER))
/* Align to TSEG size when SMM is in use */
if (CONFIG_SMM_TSEG_SIZE != 0)
return CONFIG_SMM_TSEG_SIZE;
/* Make it 8MiB by default. */
return 8*MiB;
}
void smm_region(void **start, size_t *size) void smm_region(void **start, size_t *size)
{ {
*start = (void *)sa_get_tseg_base(); *start = (void *)sa_get_tseg_base();