From 3de6d38642492b30d48b49d97f969881a863a664 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Sun, 28 May 2017 14:11:13 +0200 Subject: [PATCH] mb/lenovo/*/cmos: Remove unused option and checksum fix Fix for all Sandy-Bridge and Ivy-Bridge devices. Remove unused option "hyper_threading". Increase CMOS checksum range to cover all user adjustable settings. Change-Id: I02f7af13d9c82d7f531d4b49b3bc0e5a20c14b55 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/19955 Tested-by: build bot (Jenkins) Reviewed-by: Philipp Deppenwiese Reviewed-by: Arthur Heymans --- src/mainboard/lenovo/l520/cmos.default | 1 - src/mainboard/lenovo/l520/cmos.layout | 5 ++--- src/mainboard/lenovo/t420/cmos.default | 1 - src/mainboard/lenovo/t420/cmos.layout | 5 ++--- src/mainboard/lenovo/t420s/cmos.default | 1 - src/mainboard/lenovo/t420s/cmos.layout | 5 ++--- src/mainboard/lenovo/t430s/cmos.default | 1 - src/mainboard/lenovo/t430s/cmos.layout | 5 ++--- src/mainboard/lenovo/t520/cmos.default | 1 - src/mainboard/lenovo/t520/cmos.layout | 5 ++--- src/mainboard/lenovo/t530/cmos.default | 1 - src/mainboard/lenovo/t530/cmos.layout | 5 ++--- src/mainboard/lenovo/x1_carbon_gen1/cmos.default | 1 - src/mainboard/lenovo/x1_carbon_gen1/cmos.layout | 5 ++--- src/mainboard/lenovo/x220/cmos.default | 1 - src/mainboard/lenovo/x220/cmos.layout | 5 ++--- src/mainboard/lenovo/x230/cmos.default | 1 - src/mainboard/lenovo/x230/cmos.layout | 5 ++--- 18 files changed, 18 insertions(+), 36 deletions(-) diff --git a/src/mainboard/lenovo/l520/cmos.default b/src/mainboard/lenovo/l520/cmos.default index 526a6d6423..92dc2e1555 100644 --- a/src/mainboard/lenovo/l520/cmos.default +++ b/src/mainboard/lenovo/l520/cmos.default @@ -13,6 +13,5 @@ sata_mode=AHCI fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both hybrid_graphics_mode=Integrated Only diff --git a/src/mainboard/lenovo/l520/cmos.layout b/src/mainboard/lenovo/l520/cmos.layout index a151b7e02a..3c450c7e16 100644 --- a/src/mainboard/lenovo/l520/cmos.layout +++ b/src/mainboard/lenovo/l520/cmos.layout @@ -72,8 +72,7 @@ entries 422 2 e 10 backlight # coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused # coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -140,4 +139,4 @@ enumerations # ----------------------------------------------------------------- checksums -checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/t420/cmos.default b/src/mainboard/lenovo/t420/cmos.default index cfb75523bd..0fc3e553f6 100644 --- a/src/mainboard/lenovo/t420/cmos.default +++ b/src/mainboard/lenovo/t420/cmos.default @@ -13,5 +13,4 @@ sata_mode=AHCI fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable hybrid_graphics_mode=Integrated Only diff --git a/src/mainboard/lenovo/t420/cmos.layout b/src/mainboard/lenovo/t420/cmos.layout index 79a3a68592..924b0f11ab 100644 --- a/src/mainboard/lenovo/t420/cmos.layout +++ b/src/mainboard/lenovo/t420/cmos.layout @@ -72,8 +72,7 @@ entries #422 2 r 1 unused # coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused # coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -142,4 +141,4 @@ enumerations # ----------------------------------------------------------------- checksums -checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/t420s/cmos.default b/src/mainboard/lenovo/t420s/cmos.default index cfb75523bd..0fc3e553f6 100644 --- a/src/mainboard/lenovo/t420s/cmos.default +++ b/src/mainboard/lenovo/t420s/cmos.default @@ -13,5 +13,4 @@ sata_mode=AHCI fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable hybrid_graphics_mode=Integrated Only diff --git a/src/mainboard/lenovo/t420s/cmos.layout b/src/mainboard/lenovo/t420s/cmos.layout index ec9be116ad..e9e582db71 100644 --- a/src/mainboard/lenovo/t420s/cmos.layout +++ b/src/mainboard/lenovo/t420s/cmos.layout @@ -72,8 +72,7 @@ entries #422 2 r 1 unused # coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused # coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -142,4 +141,4 @@ enumerations # ----------------------------------------------------------------- checksums -checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/t430s/cmos.default b/src/mainboard/lenovo/t430s/cmos.default index 00e8863145..f7e38d2ee7 100644 --- a/src/mainboard/lenovo/t430s/cmos.default +++ b/src/mainboard/lenovo/t430s/cmos.default @@ -13,5 +13,4 @@ sata_mode=AHCI fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both diff --git a/src/mainboard/lenovo/t430s/cmos.layout b/src/mainboard/lenovo/t430s/cmos.layout index 73bbe3aa3d..f116bab360 100644 --- a/src/mainboard/lenovo/t430s/cmos.layout +++ b/src/mainboard/lenovo/t430s/cmos.layout @@ -72,8 +72,7 @@ entries 422 2 e 10 backlight # coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused # coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -138,4 +137,4 @@ enumerations # ----------------------------------------------------------------- checksums -checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/t520/cmos.default b/src/mainboard/lenovo/t520/cmos.default index 526a6d6423..92dc2e1555 100644 --- a/src/mainboard/lenovo/t520/cmos.default +++ b/src/mainboard/lenovo/t520/cmos.default @@ -13,6 +13,5 @@ sata_mode=AHCI fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both hybrid_graphics_mode=Integrated Only diff --git a/src/mainboard/lenovo/t520/cmos.layout b/src/mainboard/lenovo/t520/cmos.layout index a151b7e02a..3c450c7e16 100644 --- a/src/mainboard/lenovo/t520/cmos.layout +++ b/src/mainboard/lenovo/t520/cmos.layout @@ -72,8 +72,7 @@ entries 422 2 e 10 backlight # coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused # coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -140,4 +139,4 @@ enumerations # ----------------------------------------------------------------- checksums -checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/t530/cmos.default b/src/mainboard/lenovo/t530/cmos.default index 526a6d6423..92dc2e1555 100644 --- a/src/mainboard/lenovo/t530/cmos.default +++ b/src/mainboard/lenovo/t530/cmos.default @@ -13,6 +13,5 @@ sata_mode=AHCI fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both hybrid_graphics_mode=Integrated Only diff --git a/src/mainboard/lenovo/t530/cmos.layout b/src/mainboard/lenovo/t530/cmos.layout index d6d671cff1..cdcc896f12 100644 --- a/src/mainboard/lenovo/t530/cmos.layout +++ b/src/mainboard/lenovo/t530/cmos.layout @@ -72,8 +72,7 @@ entries 422 2 e 10 backlight # coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused # coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -142,4 +141,4 @@ enumerations # ----------------------------------------------------------------- checksums -checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/x1_carbon_gen1/cmos.default b/src/mainboard/lenovo/x1_carbon_gen1/cmos.default index 00e8863145..f7e38d2ee7 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/cmos.default +++ b/src/mainboard/lenovo/x1_carbon_gen1/cmos.default @@ -13,5 +13,4 @@ sata_mode=AHCI fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both diff --git a/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout b/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout index 14602fff43..3766453a8c 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout +++ b/src/mainboard/lenovo/x1_carbon_gen1/cmos.layout @@ -72,8 +72,7 @@ entries 422 2 e 10 backlight # coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused # coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -139,4 +138,4 @@ enumerations # ----------------------------------------------------------------- checksums -checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/x220/cmos.default b/src/mainboard/lenovo/x220/cmos.default index 91331ab22e..54245524ab 100644 --- a/src/mainboard/lenovo/x220/cmos.default +++ b/src/mainboard/lenovo/x220/cmos.default @@ -14,4 +14,3 @@ usb_always_on=Disable fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable diff --git a/src/mainboard/lenovo/x220/cmos.layout b/src/mainboard/lenovo/x220/cmos.layout index 0f57058ca2..77979b38a5 100644 --- a/src/mainboard/lenovo/x220/cmos.layout +++ b/src/mainboard/lenovo/x220/cmos.layout @@ -73,8 +73,7 @@ entries #423 1 r 1 unused # coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused # coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -141,4 +140,4 @@ enumerations # ----------------------------------------------------------------- checksums -checksum 392 415 984 +checksum 392 447 984 diff --git a/src/mainboard/lenovo/x230/cmos.default b/src/mainboard/lenovo/x230/cmos.default index 00e8863145..f7e38d2ee7 100644 --- a/src/mainboard/lenovo/x230/cmos.default +++ b/src/mainboard/lenovo/x230/cmos.default @@ -13,5 +13,4 @@ sata_mode=AHCI fn_ctrl_swap=Disable sticky_fn=Disable trackpoint=Enable -hyper_threading=Enable backlight=Both diff --git a/src/mainboard/lenovo/x230/cmos.layout b/src/mainboard/lenovo/x230/cmos.layout index 14602fff43..3766453a8c 100644 --- a/src/mainboard/lenovo/x230/cmos.layout +++ b/src/mainboard/lenovo/x230/cmos.layout @@ -72,8 +72,7 @@ entries 422 2 e 10 backlight # coreboot config options: cpu -424 1 e 2 hyper_threading -#425 7 r 0 unused +#424 8 r 0 unused # coreboot config options: northbridge 432 3 e 11 gfx_uma_size @@ -139,4 +138,4 @@ enumerations # ----------------------------------------------------------------- checksums -checksum 392 415 984 +checksum 392 447 984