GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ACPI: Fix IASL Warning about unused method for _S3 check 

According to the ACPI Spec for CondRefOf, the result argument is
optional.  In all of these locations, it was getting set but not
used, creating a warning in new versions of IASL.  Since it's
an optional argument, just remove it.

dsdt.aml 640:              If (CondRefOf (\_S3, Local0))
Warning  3144 - Method Local is set but never used ^  (Local0)

Change-Id: I758d198c33e585a6a4ad2c1c70f2370a01af5138
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/12693
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Martin Roth 2015-12-08 15:24:41 -07:00
parent f77516cb6d
commit 3e41ee9847
16 changed files with 35 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/amd/serengeti_cheetah/acpi/amd8111.asl
View File

@ -103,7 +103,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x08, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x08, 0x03 }) }
Else { Return (Package (0x02) { 0x08, 0x01 }) } Else { Return (Package (0x02) { 0x08, 0x01 }) }
} }
@ -112,7 +112,7 @@
Name (_ADR, 0x00000000) Name (_ADR, 0x00000000)
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x0F, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x0F, 0x03 }) }
Else { Return (Package (0x02) { 0x0F, 0x01 }) } Else { Return (Package (0x02) { 0x0F, 0x01 }) }
} }
} }
@ -122,7 +122,7 @@
Name (_ADR, 0x00000001) Name (_ADR, 0x00000001)
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x0F, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x0F, 0x03 }) }
Else { Return (Package (0x02) { 0x0F, 0x01 }) } Else { Return (Package (0x02) { 0x0F, 0x01 }) }
} }
} }

4
src/mainboard/amd/serengeti_cheetah/acpi/amd8131.asl
View File

@ -12,7 +12,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x29, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x29, 0x03 }) }
Else { Return (Package (0x02) { 0x29, 0x01 }) } Else { Return (Package (0x02) { 0x29, 0x01 }) }
} }
@ -92,7 +92,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x22, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x22, 0x03 }) }
Else { Return (Package (0x02) { 0x22, 0x01 }) } Else { Return (Package (0x02) { 0x22, 0x01 }) }
} }

4
src/mainboard/amd/serengeti_cheetah/acpi/amd8131_2.asl
View File

@ -12,7 +12,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x29, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x29, 0x03 }) }
Else { Return (Package (0x02) { 0x29, 0x01 }) } Else { Return (Package (0x02) { 0x29, 0x01 }) }
} }
@ -68,7 +68,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x22, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x22, 0x03 }) }
Else { Return (Package (0x02) { 0x22, 0x01 }) } Else { Return (Package (0x02) { 0x22, 0x01 }) }
} }

4
src/mainboard/amd/serengeti_cheetah/acpi/amd8132_2.asl
View File

@ -12,7 +12,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x29, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x29, 0x03 }) }
Else { Return (Package (0x02) { 0x29, 0x01 }) } Else { Return (Package (0x02) { 0x29, 0x01 }) }
} }
@ -68,7 +68,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x22, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x22, 0x03 }) }
Else { Return (Package (0x02) { 0x22, 0x01 }) } Else { Return (Package (0x02) { 0x22, 0x01 }) }
} }

6
src/mainboard/amd/serengeti_cheetah_fam10/acpi/amd8111.asl
View File

@ -107,7 +107,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x08, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x08, 0x03 }) }
Else { Return (Package (0x02) { 0x08, 0x01 }) } Else { Return (Package (0x02) { 0x08, 0x01 }) }
} }
@ -116,7 +116,7 @@
Name (_ADR, 0x00000000) Name (_ADR, 0x00000000)
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x0F, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x0F, 0x03 }) }
Else { Return (Package (0x02) { 0x0F, 0x01 }) } Else { Return (Package (0x02) { 0x0F, 0x01 }) }
} }
} }
@ -126,7 +126,7 @@
Name (_ADR, 0x00000001) Name (_ADR, 0x00000001)
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x0F, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x0F, 0x03 }) }
Else { Return (Package (0x02) { 0x0F, 0x01 }) } Else { Return (Package (0x02) { 0x0F, 0x01 }) }
} }
} }

4
src/mainboard/amd/serengeti_cheetah_fam10/acpi/amd8131_2.asl
View File

@ -22,7 +22,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x29, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x29, 0x03 }) }
Else { Return (Package (0x02) { 0x29, 0x01 }) } Else { Return (Package (0x02) { 0x29, 0x01 }) }
} }
@ -75,7 +75,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x22, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x22, 0x03 }) }
Else { Return (Package (0x02) { 0x22, 0x01 }) } Else { Return (Package (0x02) { 0x22, 0x01 }) }
} }

4
src/mainboard/amd/serengeti_cheetah_fam10/acpi/amd8132.asl
View File

@ -23,7 +23,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x29, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x29, 0x03 }) }
Else { Return (Package (0x02) { 0x29, 0x01 }) } Else { Return (Package (0x02) { 0x29, 0x01 }) }
} }
@ -103,7 +103,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x22, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x22, 0x03 }) }
Else { Return (Package (0x02) { 0x22, 0x01 }) } Else { Return (Package (0x02) { 0x22, 0x01 }) }
} }

4
src/mainboard/amd/serengeti_cheetah_fam10/acpi/amd8132_2.asl
View File

@ -23,7 +23,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x29, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x29, 0x03 }) }
Else { Return (Package (0x02) { 0x29, 0x01 }) } Else { Return (Package (0x02) { 0x29, 0x01 }) }
} }
@ -110,7 +110,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x22, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x22, 0x03 }) }
Else { Return (Package (0x02) { 0x22, 0x01 }) } Else { Return (Package (0x02) { 0x22, 0x01 }) }
} }

2
src/mainboard/amd/serengeti_cheetah_fam10/acpi/htx_no_ioapic.asl
View File

@ -23,7 +23,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x29, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x29, 0x03 }) }
Else { Return (Package (0x02) { 0x29, 0x01 }) } Else { Return (Package (0x02) { 0x29, 0x01 }) }
} }

8
src/mainboard/hp/dl145_g1/acpi/amd8111.asl
View File

@ -87,7 +87,7 @@ Device (TP2P) {
// result : // result :
// [0] Bit index into GPEx_EN in the GPE block described by FADT. // [0] Bit index into GPEx_EN in the GPE block described by FADT.
// [1] The lowest power state from which the system can be awakened. // [1] The lowest power state from which the system can be awakened.
//If (CondRefOf (\_S3, Local0)) { //If (CondRefOf (\_S3)) {
// Return (Package (0x02) { 0x08, 0x03 }) // Return (Package (0x02) { 0x08, 0x03 })
//} Else { //} Else {
Return (Package (0x02) { 0x08, 0x01 }) Return (Package (0x02) { 0x08, 0x01 })
@ -96,7 +96,7 @@ Device (TP2P) {
Device (ETHR) { Device (ETHR) {
Name (_ADR, 0x00010000) Name (_ADR, 0x00010000)
Method (_PRW, 0, NotSerialized) { // Power Resource for Wake Method (_PRW, 0, NotSerialized) { // Power Resource for Wake
//If (CondRefOf (\_S3, Local0)) { //If (CondRefOf (\_S3)) {
// Return (Package (0x02) { 0x08, 0x03 }) // Return (Package (0x02) { 0x08, 0x03 })
//} Else { //} Else {
Return (Package (0x02) { 0x08, 0x01 }) Return (Package (0x02) { 0x08, 0x01 })
@ -109,7 +109,7 @@ Device (TP2P) {
And (GNBL, 0x7FFF, GNBL) And (GNBL, 0x7FFF, GNBL)
} }
Method (_PRW, 0, NotSerialized) { // Power Resource for Wake Method (_PRW, 0, NotSerialized) { // Power Resource for Wake
//If (CondRefOf (\_S3, Local0)) { //If (CondRefOf (\_S3)) {
// Return (Package (0x02) { 0x0F, 0x03 }) // Return (Package (0x02) { 0x0F, 0x03 })
//} Else { //} Else {
Return (Package (0x02) { 0x0F, 0x01 }) Return (Package (0x02) { 0x0F, 0x01 })
@ -122,7 +122,7 @@ Device (TP2P) {
And (GNBL, 0x7FFF, GNBL) And (GNBL, 0x7FFF, GNBL)
} }
Method (_PRW, 0, NotSerialized) { // Power Resource for Wake Method (_PRW, 0, NotSerialized) { // Power Resource for Wake
//If (CondRefOf (\_S3, Local0)) { //If (CondRefOf (\_S3)) {
// Return (Package (0x02) { 0x0F, 0x03 }) // Return (Package (0x02) { 0x0F, 0x03 })
//} Else { //} Else {
Return (Package (0x02) { 0x0F, 0x01 }) Return (Package (0x02) { 0x0F, 0x01 })

4
src/mainboard/hp/dl145_g1/acpi/amd8131.asl
View File

@ -9,7 +9,7 @@ Device (PG0A) {
Return (DADD(GHCD(HCIN, 0), 0x00000000)) Return (DADD(GHCD(HCIN, 0), 0x00000000))
} }
Method (_PRW, 0, NotSerialized) { Method (_PRW, 0, NotSerialized) {
//If (CondRefOf (\_S3, Local0)) { //If (CondRefOf (\_S3)) {
// Return (Package (0x02) { 0x29, 0x03 }) // Return (Package (0x02) { 0x29, 0x03 })
//} Else { //} Else {
Return (Package (0x02) { 0x29, 0x01 }) Return (Package (0x02) { 0x29, 0x01 })
@ -75,7 +75,7 @@ Device (PG0B) {
Return (DADD(GHCD(HCIN, 0), 0x00010000)) Return (DADD(GHCD(HCIN, 0), 0x00010000))
} }
Method (_PRW, 0, NotSerialized) { Method (_PRW, 0, NotSerialized) {
//If (CondRefOf (\_S3, Local0)) { //If (CondRefOf (\_S3)) {
// Return (Package (0x02) { 0x22, 0x03 }) // Return (Package (0x02) { 0x22, 0x03 })
//} Else { //} Else {
Return (Package (0x02) { 0x22, 0x01 }) Return (Package (0x02) { 0x22, 0x01 })

6
src/mainboard/iwill/dk8_htx/acpi/amd8111.asl
View File

@ -103,7 +103,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x08, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x08, 0x03 }) }
Else { Return (Package (0x02) { 0x08, 0x01 }) } Else { Return (Package (0x02) { 0x08, 0x01 }) }
} }
@ -112,7 +112,7 @@
Name (_ADR, 0x00000000) Name (_ADR, 0x00000000)
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x0F, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x0F, 0x03 }) }
Else { Return (Package (0x02) { 0x0F, 0x01 }) } Else { Return (Package (0x02) { 0x0F, 0x01 }) }
} }
} }
@ -122,7 +122,7 @@
Name (_ADR, 0x00000001) Name (_ADR, 0x00000001)
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x0F, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x0F, 0x03 }) }
Else { Return (Package (0x02) { 0x0F, 0x01 }) } Else { Return (Package (0x02) { 0x0F, 0x01 }) }
} }
} }

4
src/mainboard/iwill/dk8_htx/acpi/amd8131.asl
View File

@ -12,7 +12,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x29, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x29, 0x03 }) }
Else { Return (Package (0x02) { 0x29, 0x01 }) } Else { Return (Package (0x02) { 0x29, 0x01 }) }
} }
@ -92,7 +92,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x22, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x22, 0x03 }) }
Else { Return (Package (0x02) { 0x22, 0x01 }) } Else { Return (Package (0x02) { 0x22, 0x01 }) }
} }

4
src/mainboard/iwill/dk8_htx/acpi/amd8131_2.asl
View File

@ -12,7 +12,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x29, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x29, 0x03 }) }
Else { Return (Package (0x02) { 0x29, 0x01 }) } Else { Return (Package (0x02) { 0x29, 0x01 }) }
} }
@ -68,7 +68,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x22, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x22, 0x03 }) }
Else { Return (Package (0x02) { 0x22, 0x01 }) } Else { Return (Package (0x02) { 0x22, 0x01 }) }
} }

4
src/mainboard/iwill/dk8_htx/acpi/amd8132_2.asl
View File

@ -12,7 +12,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x29, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x29, 0x03 }) }
Else { Return (Package (0x02) { 0x29, 0x01 }) } Else { Return (Package (0x02) { 0x29, 0x01 }) }
} }
@ -68,7 +68,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x22, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x22, 0x03 }) }
Else { Return (Package (0x02) { 0x22, 0x01 }) } Else { Return (Package (0x02) { 0x22, 0x01 }) }
} }

2
src/mainboard/iwill/dk8_htx/acpi/htx_no_ioapic.asl
View File

@ -12,7 +12,7 @@
Method (_PRW, 0, NotSerialized) Method (_PRW, 0, NotSerialized)
{ {
If (CondRefOf (\_S3, Local0)) { Return (Package (0x02) { 0x29, 0x03 }) } If (CondRefOf (\_S3)) { Return (Package (0x02) { 0x29, 0x03 }) }
Else { Return (Package (0x02) { 0x29, 0x01 }) } Else { Return (Package (0x02) { 0x29, 0x01 }) }
} }