From 3e88b18bb6e951625451e43a6dee4595c5714d35 Mon Sep 17 00:00:00 2001 From: Lijian Zhao Date: Fri, 25 Jan 2019 23:20:16 -0800 Subject: [PATCH] util/ifdtool: Add lock support for CNL and ICL Cannonlake and Icelake have same read/write region permission settings with skylake and kabylake, so add it here as well. BUG=b:123199222 TEST=Turn on CONFIG_LOCK_MANAGEMENT_ENGINE and build image, check the setting matches 0x0D for read and 0x04 for write. Signed-off-by: Lijian Zhao Change-Id: I71d8b815c7dff7dcbcff2bf77c85ebf80b8df6d2 Reviewed-on: https://review.coreboot.org/c/31104 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer Reviewed-by: Paul Menzel --- util/ifdtool/ifdtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 69cd2a9fef..1181e8c817 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -965,6 +965,8 @@ static void lock_descriptor(const char *filename, char *image, int size) /* TXE can only write Device Expansion */ fmba->flmstr2 |= 0x20 << wr_shift; break; + case PLATFORM_CNL: + case PLATFORM_ICL: case PLATFORM_SKLKBL: /* CPU/BIOS can read descriptor, BIOS and GbE. */ fmba->flmstr1 |= 0xb << rd_shift;