mainboards: fix spd generation
echo is evaluated by a shell builtin producing non-binary spd data of the form '-e -n \<byte>'. Correct this by using printf builtin which does the equivalent and is more cross platform friendly. Boards changed: gizmosphere/gizmo gizmosphere/gizmo2 google/bolt google/falco google/link google/peppy google/rambi google/samus google/slippy pcengines/apu1 Change-Id: Iefdaf59903b9682cc88c94fd991883b560616492 Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: http://review.coreboot.org/9196 Tested-by: build bot (Jenkins) Reviewed-by: Marc Jones <marc.jones@se-eng.com> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
parent
a30f7e667c
commit
3e91cffd89
|
@ -45,7 +45,7 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.
|
||||||
$(SPD_BIN): $(SPD_DEPS)
|
$(SPD_BIN): $(SPD_DEPS)
|
||||||
for f in $+; \
|
for f in $+; \
|
||||||
do for c in $$(cat $$f | grep -v ^#); \
|
do for c in $$(cat $$f | grep -v ^#); \
|
||||||
do echo -e -n "\\x$$c"; \
|
do printf $$(printf '\%o' 0x$$c); \
|
||||||
done; \
|
done; \
|
||||||
done > $@
|
done > $@
|
||||||
|
|
||||||
|
|
|
@ -38,7 +38,7 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.
|
||||||
$(SPD_BIN): $(SPD_DEPS)
|
$(SPD_BIN): $(SPD_DEPS)
|
||||||
for f in $+; \
|
for f in $+; \
|
||||||
do for c in $$(cat $$f | grep -v ^#); \
|
do for c in $$(cat $$f | grep -v ^#); \
|
||||||
do echo -e -n "\\x$$c"; \
|
do printf $$(printf '\%o' 0x$$c); \
|
||||||
done; \
|
done; \
|
||||||
done > $@
|
done > $@
|
||||||
|
|
||||||
|
|
|
@ -36,7 +36,7 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.
|
||||||
$(SPD_BIN): $(SPD_DEPS)
|
$(SPD_BIN): $(SPD_DEPS)
|
||||||
for f in $+; \
|
for f in $+; \
|
||||||
do for c in $$(cat $$f | grep -v ^#); \
|
do for c in $$(cat $$f | grep -v ^#); \
|
||||||
do echo -e -n "\\x$$c"; \
|
do printf $$(printf '\%o' 0x$$c); \
|
||||||
done; \
|
done; \
|
||||||
done > $@
|
done > $@
|
||||||
|
|
||||||
|
|
|
@ -44,7 +44,7 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.
|
||||||
$(SPD_BIN): $(SPD_DEPS)
|
$(SPD_BIN): $(SPD_DEPS)
|
||||||
for f in $+; \
|
for f in $+; \
|
||||||
do for c in $$(cat $$f | grep -v ^#); \
|
do for c in $$(cat $$f | grep -v ^#); \
|
||||||
do echo -e -n "\\x$$c"; \
|
do printf $$(printf '\%o' 0x$$c); \
|
||||||
done; \
|
done; \
|
||||||
done > $@
|
done > $@
|
||||||
|
|
||||||
|
|
|
@ -37,7 +37,11 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.
|
||||||
|
|
||||||
# Include spd rom data
|
# Include spd rom data
|
||||||
$(SPD_BIN): $(SPD_DEPS)
|
$(SPD_BIN): $(SPD_DEPS)
|
||||||
for f in $^; do for c in $$(cat $$f); do echo -e -n "\\x$$c"; done; done > $@
|
for f in $+; \
|
||||||
|
do for c in $$(cat $$f | grep -v ^#); \
|
||||||
|
do printf $$(printf '\%o' 0x$$c); \
|
||||||
|
done; \
|
||||||
|
done > $@
|
||||||
|
|
||||||
cbfs-files-y += spd.bin
|
cbfs-files-y += spd.bin
|
||||||
spd.bin-file := $(SPD_BIN)
|
spd.bin-file := $(SPD_BIN)
|
||||||
|
|
|
@ -43,7 +43,7 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.
|
||||||
$(SPD_BIN): $(SPD_DEPS)
|
$(SPD_BIN): $(SPD_DEPS)
|
||||||
for f in $+; \
|
for f in $+; \
|
||||||
do for c in $$(cat $$f | grep -v ^#); \
|
do for c in $$(cat $$f | grep -v ^#); \
|
||||||
do echo -e -n "\\x$$c"; \
|
do printf $$(printf '\%o' 0x$$c); \
|
||||||
done; \
|
done; \
|
||||||
done > $@
|
done > $@
|
||||||
|
|
||||||
|
|
|
@ -40,7 +40,7 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).
|
||||||
$(SPD_BIN): $(SPD_DEPS)
|
$(SPD_BIN): $(SPD_DEPS)
|
||||||
for f in $+; \
|
for f in $+; \
|
||||||
do for c in $$(cat $$f | grep -v ^#); \
|
do for c in $$(cat $$f | grep -v ^#); \
|
||||||
do echo -e -n "\\x$$c"; \
|
do printf $$(printf '\%o' 0x$$c); \
|
||||||
done; \
|
done; \
|
||||||
done > $@
|
done > $@
|
||||||
|
|
||||||
|
|
|
@ -45,7 +45,7 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).
|
||||||
$(SPD_BIN): $(SPD_DEPS)
|
$(SPD_BIN): $(SPD_DEPS)
|
||||||
for f in $+; \
|
for f in $+; \
|
||||||
do for c in $$(cat $$f | grep -v ^#); \
|
do for c in $$(cat $$f | grep -v ^#); \
|
||||||
do echo -e -n "\\x$$c"; \
|
do printf $$(printf '\%o' 0x$$c); \
|
||||||
done; \
|
done; \
|
||||||
done > $@
|
done > $@
|
||||||
|
|
||||||
|
|
|
@ -37,7 +37,7 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.
|
||||||
$(SPD_BIN): $(SPD_DEPS)
|
$(SPD_BIN): $(SPD_DEPS)
|
||||||
for f in $+; \
|
for f in $+; \
|
||||||
do for c in $$(cat $$f | grep -v ^#); \
|
do for c in $$(cat $$f | grep -v ^#); \
|
||||||
do echo -e -n "\\x$$c"; \
|
do printf $$(printf '\%o' 0x$$c); \
|
||||||
done; \
|
done; \
|
||||||
done > $@
|
done > $@
|
||||||
|
|
||||||
|
|
|
@ -47,7 +47,7 @@ SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/$(f).spd.
|
||||||
$(SPD_BIN): $(SPD_DEPS)
|
$(SPD_BIN): $(SPD_DEPS)
|
||||||
for f in $+; \
|
for f in $+; \
|
||||||
do for c in $$(cat $$f | grep -v ^#); \
|
do for c in $$(cat $$f | grep -v ^#); \
|
||||||
do echo -e -n "\\x$$c"; \
|
do printf $$(printf '\%o' 0x$$c); \
|
||||||
done; \
|
done; \
|
||||||
done > $@
|
done > $@
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue