GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/uart/Kconfig: Be smarter about DRIVERS_UART_8250IO 

It defaults to y to avoid having to select it per mainboard. But that
makes a mess because it results in linker conflicts unless other UART
drivers disable it explicitly.

We try to be smarter about the default value for now. The real solu-
tion would be to hardcode it per mainboard. But who knows which boards
actually have it?

Change-Id: I7e755fe0e4f6d1c31ef2854603a5510c3cdc4967
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/29571
Reviewed-by: Julius Werner <jwerner@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nico Huber 2018-11-11 00:27:41 +01:00
parent 87ca3898f9
commit 3eb720c36e
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/drivers/uart/Kconfig
View File

@ -4,8 +4,11 @@ config DRIVERS_UART
default n default n
config DRIVERS_UART_8250IO config DRIVERS_UART_8250IO
# FIXME: Shouldn't have a prompt, should default to n, and
# should be selected by boards that have it instead.
bool "Serial port on SuperIO" bool "Serial port on SuperIO"
depends on ARCH_X86 depends on ARCH_X86
default n if DRIVERS_UART_8250MEM || HAVE_UART_SPECIAL
default n if NO_UART_ON_SUPERIO default n if NO_UART_ON_SUPERIO
default y default y

2
src/soc/intel/denverton_ns/Kconfig
View File

@ -162,7 +162,7 @@ config LEGACY_UART_MODE
endchoice endchoice
config ENABLE_HSUART config ENABLE_HSUART
depends on (!DRIVERS_UART_8250IO && NON_LEGACY_UART_MODE) depends on NON_LEGACY_UART_MODE
bool "Enable High-speed UART debug port selected by UART_FOR_CONSOLE." bool "Enable High-speed UART debug port selected by UART_FOR_CONSOLE."
default n default n
select CONSOLE_SERIAL select CONSOLE_SERIAL