mb/google/rex: Require VBOOT_LID_SWITCH for Chromebook design
This patch ensures that platforms with lids, such as Chromebooks, only select the VBOOT_LID_SWITCH configuration option. Only samples the LID GPIO if VBOOT_LID_SWITCH config is enabled, otherwise fake LID is open to avoid shutdown after reaching depthcharge. Tested by building and booting Google/Rex with the VBOOT_LID_SWITCH configuration option enabled, and verifying that google/ovis does not required VBOOT_LID_SWITCH config. Change-Id: Ic5123b822a5a7021023319cb08a3f9e5225961ba Signed-off-by: Subrata Banik <subratabanik@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77693 Reviewed-by: Nick Vaccaro <nvaccaro@google.com> Reviewed-by: Jakub Czapiga <jacz@semihalf.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kapil Porwal <kapilporwal@google.com>
This commit is contained in:
parent
79503ef515
commit
3ff6b2ff9e
|
@ -160,7 +160,7 @@ config MEMORY_SOLDERDOWN
|
|||
select HAVE_SPD_IN_CBFS
|
||||
|
||||
config VBOOT
|
||||
select VBOOT_LID_SWITCH
|
||||
select VBOOT_LID_SWITCH if BOARD_GOOGLE_BASEBOARD_REX
|
||||
|
||||
config UART_FOR_CONSOLE
|
||||
int
|
||||
|
|
|
@ -9,7 +9,12 @@
|
|||
void fill_lb_gpios(struct lb_gpios *gpios)
|
||||
{
|
||||
struct lb_gpio chromeos_gpios[] = {
|
||||
#if CONFIG(VBOOT_LID_SWITCH)
|
||||
{-1, ACTIVE_HIGH, get_lid_switch(), "lid"},
|
||||
#else
|
||||
/* fake LID open to avoid shutdown in depthcharge */
|
||||
{-1, ACTIVE_HIGH, 1, "lid"},
|
||||
#endif
|
||||
{-1, ACTIVE_HIGH, 0, "power"},
|
||||
{-1, ACTIVE_HIGH, gfx_get_init_done(), "oprom"},
|
||||
{-1, ACTIVE_HIGH, 0, "EC in RW"},
|
||||
|
|
Loading…
Reference in New Issue