GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/rex: Require VBOOT_LID_SWITCH for Chromebook design 

This patch ensures that platforms with lids, such as Chromebooks, only
select the VBOOT_LID_SWITCH configuration option.

Only samples the LID GPIO if VBOOT_LID_SWITCH config is enabled,
otherwise fake LID is open to avoid shutdown after reaching
depthcharge.

Tested by building and booting Google/Rex with the VBOOT_LID_SWITCH
configuration option enabled, and verifying that google/ovis does not
required VBOOT_LID_SWITCH config.

Change-Id: Ic5123b822a5a7021023319cb08a3f9e5225961ba
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77693
Reviewed-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-by: Jakub Czapiga <jacz@semihalf.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
This commit is contained in:
Subrata Banik 2023-09-07 12:57:42 +00:00 committed by Jakub Czapiga
parent 79503ef515
commit 3ff6b2ff9e
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/rex/Kconfig
View File

@ -160,7 +160,7 @@ config MEMORY_SOLDERDOWN
select HAVE_SPD_IN_CBFS select HAVE_SPD_IN_CBFS
config VBOOT config VBOOT
select VBOOT_LID_SWITCH select VBOOT_LID_SWITCH if BOARD_GOOGLE_BASEBOARD_REX
config UART_FOR_CONSOLE config UART_FOR_CONSOLE
int int

5
src/mainboard/google/rex/chromeos.c
View File

@ -9,7 +9,12 @@
void fill_lb_gpios(struct lb_gpios *gpios) void fill_lb_gpios(struct lb_gpios *gpios)
{ {
struct lb_gpio chromeos_gpios[] = { struct lb_gpio chromeos_gpios[] = {
#if CONFIG(VBOOT_LID_SWITCH)
{-1, ACTIVE_HIGH, get_lid_switch(), "lid"}, {-1, ACTIVE_HIGH, get_lid_switch(), "lid"},
#else
/* fake LID open to avoid shutdown in depthcharge */
{-1, ACTIVE_HIGH, 1, "lid"},
#endif
{-1, ACTIVE_HIGH, 0, "power"}, {-1, ACTIVE_HIGH, 0, "power"},
{-1, ACTIVE_HIGH, gfx_get_init_done(), "oprom"}, {-1, ACTIVE_HIGH, gfx_get_init_done(), "oprom"},
{-1, ACTIVE_HIGH, 0, "EC in RW"}, {-1, ACTIVE_HIGH, 0, "EC in RW"},