From 404188f80e7733610fd8d8611b55107f4e1f6431 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Wed, 18 May 2022 09:30:03 +0200 Subject: [PATCH] vendorcode/amd/agesa: Remove -fno-zero-initialized-in-bss MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There are zero-initialized arrays within AGESA that were previously not declared with CONST qualifier. Without this flag, such arrays would have consumed valuable CAR space in romstage. After adding CONST qualifiers these arrays have actually moved to .rodata and removing the flag does not add anything to .bss. TEST: see that BUILD_TIMELESS=1 results in the same binary. Change-Id: I5b91deb1bf1b64bd9c88dc311db4e0b36df86c18 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/64445 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki Reviewed-by: Martin L Roth --- src/vendorcode/amd/agesa/Makefile.inc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/vendorcode/amd/agesa/Makefile.inc b/src/vendorcode/amd/agesa/Makefile.inc index 73a87a3c5a..9ef7f5cd19 100644 --- a/src/vendorcode/amd/agesa/Makefile.inc +++ b/src/vendorcode/amd/agesa/Makefile.inc @@ -9,7 +9,6 @@ subdirs-y += common classes-y += libagesa libagesa-y = libagesa-generic-ccopts += -D__LIBAGESA__ -libagesa-generic-ccopts += -fno-zero-initialized-in-bss libagesa-generic-ccopts += $(AGESA_INC) $(AGESA_AUTOINCLUDES) libagesa-generic-ccopts += -Wno-pragma-pack -Wno-unused-but-set-variable libagesa-generic-ccopts += -Wno-implicit-fallthrough