From 40ad842ade3d3b4178b26034b00a06162fd5e5ab Mon Sep 17 00:00:00 2001
From: Patrick Georgi <patrick@georgi-clan.de>
Date: Sat, 21 May 2011 22:18:59 +0000
Subject: [PATCH] Add regression test for build directory handling to make lint
 target

A couple of scenarios that were fixed in the last few revisions are
tested to ensure that it's easy to determine breakage.

Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Acked-by: Patrick Georgi <patrick@georgi-clan.de>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6607 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
---
 Makefile                              |  2 +
 util/lint/lint-002-build-dir-handling | 63 +++++++++++++++++++++++++++
 2 files changed, 65 insertions(+)
 create mode 100755 util/lint/lint-002-build-dir-handling

diff --git a/Makefile b/Makefile
index 04fbb02612..5082f7e729 100644
--- a/Makefile
+++ b/Makefile
@@ -237,7 +237,9 @@ printall:
 
 endif
 
+ifndef NOMKDIR
 $(shell mkdir -p $(obj) $(objutil)/kconfig/lxdialog $(additional-dirs) $(alldirs))
+endif
 
 cscope:
 	cscope -bR
diff --git a/util/lint/lint-002-build-dir-handling b/util/lint/lint-002-build-dir-handling
new file mode 100755
index 0000000000..39e3124f93
--- /dev/null
+++ b/util/lint/lint-002-build-dir-handling
@@ -0,0 +1,63 @@
+#!/bin/sh
+# This file is part of the coreboot project.
+#
+# Copyright (C) 2011 Patrick Georgi <patrick@georgi-clan.de>
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; version 2 of the License.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# DESCR: Check that build directories can be chosen freely
+
+# $1: command to test for GNU make
+search_make() {
+if [ -n "`$1 --version 2>&1 |grep GNU`" ]; then MAKE=$1; fi
+}
+
+# if $1 and $2 differ, exit with failure
+compare_output() {
+if ! [ "$1" = "$2" ]; then
+	echo \'$1\' should be \'$2\'
+	exit 1
+fi
+}
+
+# $1: object directory
+run_printall() {
+$MAKE NOMKDIR=1 DOTCONFIG=$TMPCONFIG obj=$1 printall |sed -e "s,^ *,," -e "s, ,\n,g" -e "s,^ramstage-objs:=,," -e "s,mainboard/[^/]*/[^/]*/,.../," |grep "/static.*\.[co]" |sort |tr '\012\015' '  ' |sed -e "s,  *, ,g" -e "s, *$,,"
+}
+
+# find GNU make
+search_make make
+search_make gmake
+search_make gnumake
+
+if [ "$MAKE" = "" ]; then
+	echo Could not identify GNU make
+	exit 1
+fi
+
+# prepare a config to use
+TMPCONFIG=`mktemp`
+rm -f $TMPCONFIG
+$MAKE NOMKDIR=1 DOTCONFIG=$TMPCONFIG allyesconfig >/dev/null
+
+# look up parent directory
+PARENTDIR=`dirname $PWD`
+
+compare_output "`run_printall build`" "build/.../static.c build/.../static.ramstage.o"
+compare_output "`run_printall ../obj`" "$PARENTDIR/obj/.../static.c $PARENTDIR/obj/.../static.ramstage.o"
+compare_output "`run_printall /tmp`" "/tmp/.../static.c /tmp/.../static.ramstage.o"
+compare_output "`run_printall /../tmp`" "/tmp/.../static.c /tmp/.../static.ramstage.o"
+
+rm -f $TMPCONFIG
+