GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google/chromeec: fix the error status passing 

Various instances of google_chromeec_command() can return non-zero number
(both positive and negative) to indicate error -- fixing cbi_get_uint32()
and cbi_get_string() so they follow the same convention.

BUG=b:123676982
BRANCH=kukui
TEST=build with kukui/flapjack configurations
Signed-off-by: YH Lin <yueherngl@google.com>
Change-Id: I7f0a8a61d01d942cba57036a17dd527fdbbf940c
Reviewed-on: https://review.coreboot.org/c/31585
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
YH Lin 2019-02-26 09:56:06 -08:00 committed by Patrick Georgi
parent b47c633c31
commit 40f65425e4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/ec/google/chromeec/ec.c
View File

@ -595,7 +595,7 @@ static int cbi_get_uint32(uint32_t *id, uint32_t tag)
cmd.cmd_dev_index = 0;
rv = google_chromeec_command(&cmd);
if (rv < 0)
if (rv != 0)
return rv;
*id = r;
return 0;
@ -627,7 +627,7 @@ static int cbi_get_string(char *buf, size_t bufsize, uint32_t tag)
int rv;
rv = google_chromeec_command(&cmd);
if (rv < 0)
if (rv != 0)
return rv;
/* Ensure NUL termination. */