mb/*/*/devicetree.cb: Normalize disabled PIRQ values

If bit 7 of a PIRQ route is set, it is disabled. Modern OSes don't use
PIRQ routing, so we might as well zero the other bits for consistency.

Tested on Asrock B85M Pro4 with SeaBIOS 1.13.0, still boots.

Change-Id: I78980b9ea5e878a6200df0f6c18c5e7d06a7950a
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43861
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2020-07-25 13:44:34 +02:00
parent 7417bb0e5a
commit 4276050d13
12 changed files with 57 additions and 57 deletions

View File

@ -27,14 +27,14 @@ chip northbridge/intel/haswell
chip southbridge/intel/lynxpoint chip southbridge/intel/lynxpoint
register "gen1_dec" = "0x000c0291" # Super I/O HWM register "gen1_dec" = "0x000c0291" # Super I/O HWM
register "pirqa_routing" = "0x8b" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x80" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x83" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x8a" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x83" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x8b" register "pirqg_routing" = "0x80"
register "pirqh_routing" = "0x8a" register "pirqh_routing" = "0x80"
register "sata_ahci" = "1" register "sata_ahci" = "1"
register "sata_port_map" = "0x3f" register "sata_port_map" = "0x3f"

View File

@ -35,14 +35,14 @@ chip northbridge/intel/haswell
end end
chip southbridge/intel/lynxpoint chip southbridge/intel/lynxpoint
register "pirqa_routing" = "0x8b" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x80" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x8b" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x8a" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x80" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x80" register "pirqg_routing" = "0x80"
register "pirqh_routing" = "0x8a" register "pirqh_routing" = "0x80"
register "sata_ahci" = "1" register "sata_ahci" = "1"
register "sata_port_map" = "0x33" register "sata_port_map" = "0x33"

View File

@ -25,14 +25,14 @@ chip northbridge/intel/i945
end end
chip southbridge/intel/i82801gx chip southbridge/intel/i82801gx
register "pirqa_routing" = "0x8b" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x8a" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x86" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x85" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x83" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x80" register "pirqg_routing" = "0x80"
register "pirqh_routing" = "0x85" register "pirqh_routing" = "0x80"
register "gpe0_en" = "0" register "gpe0_en" = "0"

View File

@ -27,14 +27,14 @@ chip northbridge/intel/i945
end end
chip southbridge/intel/i82801gx chip southbridge/intel/i82801gx
register "pirqa_routing" = "0x8c" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x8a" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x83" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x8b" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x80" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x80" register "pirqg_routing" = "0x80"
register "pirqh_routing" = "0x85" register "pirqh_routing" = "0x80"
# GPI routing # GPI routing
# 0 No effect (default) # 0 No effect (default)

View File

@ -15,10 +15,10 @@ chip soc/intel/broadwell
# Set backlight PWM value for eDP # Set backlight PWM value for eDP
register "gpu_pch_backlight_pwm_hz" = "200" register "gpu_pch_backlight_pwm_hz" = "200"
register "pirqa_routing" = "0x8b" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x8a" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x8b" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x8b" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x80" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x80" register "pirqg_routing" = "0x80"

View File

@ -36,10 +36,10 @@ chip northbridge/intel/haswell
device pci 03.0 on end # mini-hd audio device pci 03.0 on end # mini-hd audio
chip southbridge/intel/lynxpoint chip southbridge/intel/lynxpoint
register "pirqa_routing" = "0x8b" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x8a" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x8b" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x8b" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x80" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x80" register "pirqg_routing" = "0x80"

View File

@ -9,10 +9,10 @@ chip soc/intel/broadwell
# Enable HDMI Hotplug with 6ms pulse # Enable HDMI Hotplug with 6ms pulse
register "gpu_dp_b_hotplug" = "0x06" register "gpu_dp_b_hotplug" = "0x06"
register "pirqa_routing" = "0x8b" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x8a" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x8b" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x8b" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x80" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x80" register "pirqg_routing" = "0x80"

View File

@ -40,10 +40,10 @@ chip northbridge/intel/haswell
device pci 03.0 on end # mini-hd audio device pci 03.0 on end # mini-hd audio
chip southbridge/intel/lynxpoint chip southbridge/intel/lynxpoint
register "pirqa_routing" = "0x8b" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x8a" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x8b" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x8b" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x80" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x80" register "pirqg_routing" = "0x80"

View File

@ -32,10 +32,10 @@ chip northbridge/intel/haswell
device pci 02.0 on end # vga controller device pci 02.0 on end # vga controller
chip southbridge/intel/lynxpoint # Intel Series 8 Lynx Point PCH chip southbridge/intel/lynxpoint # Intel Series 8 Lynx Point PCH
register "pirqa_routing" = "0x8b" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x8a" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x8b" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x8b" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x80" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x80" register "pirqg_routing" = "0x80"

View File

@ -9,10 +9,10 @@ chip soc/intel/broadwell
# Enable DVI Hotplug with 6ms pulse # Enable DVI Hotplug with 6ms pulse
register "gpu_dp_b_hotplug" = "0x06" register "gpu_dp_b_hotplug" = "0x06"
register "pirqa_routing" = "0x8b" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x8a" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x8b" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x8b" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x80" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x80" register "pirqg_routing" = "0x80"

View File

@ -38,14 +38,14 @@ chip northbridge/intel/haswell
register "gen4_dec" = "0x000c06a1" register "gen4_dec" = "0x000c06a1"
register "gpi13_routing" = "2" register "gpi13_routing" = "2"
register "gpi1_routing" = "2" register "gpi1_routing" = "2"
register "pirqa_routing" = "0x8b" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x8a" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x8a" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x89" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x86" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x8b" register "pirqg_routing" = "0x80"
register "pirqh_routing" = "0x87" register "pirqh_routing" = "0x80"
register "sata_ahci" = "1" register "sata_ahci" = "1"
# 0(HDD), 1(M.2), 5(ODD) # 0(HDD), 1(M.2), 5(ODD)
register "sata_port_map" = "0x23" register "sata_port_map" = "0x23"

View File

@ -26,14 +26,14 @@ chip northbridge/intel/haswell
device pci 03.0 off end # Mini-HD audio device pci 03.0 off end # Mini-HD audio
chip southbridge/intel/lynxpoint chip southbridge/intel/lynxpoint
register "pirqa_routing" = "0x8b" register "pirqa_routing" = "0x80"
register "pirqb_routing" = "0x8a" register "pirqb_routing" = "0x80"
register "pirqc_routing" = "0x8b" register "pirqc_routing" = "0x80"
register "pirqd_routing" = "0x8a" register "pirqd_routing" = "0x80"
register "pirqe_routing" = "0x80" register "pirqe_routing" = "0x80"
register "pirqf_routing" = "0x80" register "pirqf_routing" = "0x80"
register "pirqg_routing" = "0x80" register "pirqg_routing" = "0x80"
register "pirqh_routing" = "0x85" register "pirqh_routing" = "0x80"
register "sata_ahci" = "1" register "sata_ahci" = "1"
register "sata_port_map" = "0x3f" register "sata_port_map" = "0x3f"