From 4280b434736870dac9bb177675f6f1051bd06d54 Mon Sep 17 00:00:00 2001 From: Francois Toguo Date: Thu, 25 Feb 2021 15:04:56 -0800 Subject: [PATCH] soc/intel/tigerlake: Re-use existing define in CrashLog implementation TEL_CFG_BAR variables have the same value as PCI_BASE_ADDRESS. This fix re-uses an already existing variable in crashLog. BUG=None TEST=CrashLog data generated, extracted, processed, decoded sucessfully on delbin. Signed-off-by: Francois Toguo Change-Id: If063d1ea4189dbc5a75f37d86ce158e8f1bd808d Reviewed-on: https://review.coreboot.org/c/coreboot/+/51096 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Tim Wawrzynczak Reviewed-by: Angel Pons --- src/soc/intel/tigerlake/crashlog_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/intel/tigerlake/crashlog_lib.c b/src/soc/intel/tigerlake/crashlog_lib.c index c9b1e6154c..93baf0442f 100644 --- a/src/soc/intel/tigerlake/crashlog_lib.c +++ b/src/soc/intel/tigerlake/crashlog_lib.c @@ -220,9 +220,9 @@ bool cpu_cl_discovery(void) printk(BIOS_DEBUG, "tmp_bar_addr: 0x%X\n", tmp_bar_addr); if (cpu_cl_devsc_cap.discovery_data.fields.t_bir_q == TEL_DVSEC_TBIR_BAR0) { - pci_write_config32(SA_DEV_TMT, TEL_CFG_BAR0, tmp_bar_addr); + pci_write_config32(SA_DEV_TMT, PCI_BASE_ADDRESS_0, tmp_bar_addr); } else if (cpu_cl_devsc_cap.discovery_data.fields.t_bir_q == TEL_DVSEC_TBIR_BAR1) { - pci_write_config32(SA_DEV_TMT, TEL_CFG_BAR1, tmp_bar_addr); + pci_write_config32(SA_DEV_TMT, PCI_BASE_ADDRESS_1, tmp_bar_addr); } else { printk(BIOS_DEBUG, "invalid discovery data t_bir_q: 0x%x\n", cpu_cl_devsc_cap.discovery_data.fields.t_bir_q);