GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/purism/librem_skl: Clean up FSP-M RCOMP settings 

There's no need to use static functions to fill these settings in. Also,
add missing include for <stdint.h> and initialize `mem_cfg` in one line.

Change-Id: I82b0997846d4ec40cf9b1a8ebfb1e881b194e078
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46252
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by:  Felix Singer <felixsinger@posteo.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2020-10-09 23:24:31 +02:00 committed by Patrick Georgi
parent 965439be12
commit 42aa2cb94a
1 changed files with 11 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/mainboard/purism/librem_skl/romstage.c
View File

@ -3,37 +3,30 @@
#include <assert.h> #include <assert.h>
#include <soc/romstage.h> #include <soc/romstage.h>
#include <spd_bin.h> #include <spd_bin.h>
#include <stdint.h>
#include <string.h> #include <string.h>
static void mainboard_fill_rcomp_res_data(void *rcomp_ptr)
{
/* Rcomp resistor */
const u16 RcompResistor[3] = { 121, 81, 100 };
memcpy(rcomp_ptr, RcompResistor, sizeof(RcompResistor));
}
static void mainboard_fill_rcomp_strength_data(void *rcomp_strength_ptr)
{
/* Rcomp target */
const u16 RcompTarget[5] = { 100, 40, 20, 20, 26 };
memcpy(rcomp_strength_ptr, RcompTarget, sizeof(RcompTarget));
}
void mainboard_memory_init_params(FSPM_UPD *mupd) void mainboard_memory_init_params(FSPM_UPD *mupd)
{ {
FSP_M_CONFIG *mem_cfg; const u16 rcomp_resistors[3] = { 121, 81, 100 };
const u16 rcomp_targets[5] = { 100, 40, 20, 20, 26 };
FSP_M_CONFIG *mem_cfg = &mupd->FspmConfig;
struct spd_block blk = { struct spd_block blk = {
.addr_map = { 0x50 }, .addr_map = { 0x50 },
}; };
mem_cfg = &mupd->FspmConfig; assert(sizeof(mem_cfg->RcompResistor) == sizeof(rcomp_resistors));
assert(sizeof(mem_cfg->RcompTarget) == sizeof(rcomp_targets));
get_spd_smbus(&blk); get_spd_smbus(&blk);
dump_spd_info(&blk); dump_spd_info(&blk);
assert(blk.spd_array[0][0] != 0); assert(blk.spd_array[0][0] != 0);
mainboard_fill_rcomp_res_data(&mem_cfg->RcompResistor); memcpy(mem_cfg->RcompResistor, rcomp_resistors, sizeof(mem_cfg->RcompResistor));
mainboard_fill_rcomp_strength_data(&mem_cfg->RcompTarget); memcpy(mem_cfg->RcompTarget, rcomp_targets, sizeof(mem_cfg->RcompTarget));
mem_cfg->DqPinsInterleaved = TRUE; mem_cfg->DqPinsInterleaved = TRUE;
mem_cfg->MemorySpdDataLen = blk.len; mem_cfg->MemorySpdDataLen = blk.len;