GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mainboard: Get CHROMEOS/MAINBOARD_HAS_CHROMEOS right (again) 

CHROMEOS is a user-visible bool. It must not be 'select'ed in Kconfig.
That's why we have MAINBOARD_HAS_CHROMEOS. This is the fifth time I
find this being used wrong.
Why is this confusing/so hard to get right?

Change-Id: Icb4629355c63508f5a044b46842524b3d203c2da
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: http://review.coreboot.org/11290
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Alexandru Gagniuc 2015-08-20 12:51:48 -04:00
parent af473ede1f
commit 43213be116
5 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/cyan/Kconfig
View File

@ -5,7 +5,6 @@ config BOARD_SPECIFIC_OPTIONS
select VGA_ROM_RUN if !PAYLOAD_SEABIOS select VGA_ROM_RUN if !PAYLOAD_SEABIOS
select ALWAYS_LOAD_OPROM if !PAYLOAD_SEABIOS select ALWAYS_LOAD_OPROM if !PAYLOAD_SEABIOS
select BOARD_ROMSIZE_KB_8192 select BOARD_ROMSIZE_KB_8192
select CHROMEOS
select CHROMEOS_VBNV_CMOS select CHROMEOS_VBNV_CMOS
select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC
select EC_GOOGLE_CHROMEEC_MEC select EC_GOOGLE_CHROMEEC_MEC

1
src/mainboard/google/glados/Kconfig
View File

@ -4,7 +4,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
def_bool y def_bool y
select BOARD_ROMSIZE_KB_16384 select BOARD_ROMSIZE_KB_16384
select CACHE_ROM select CACHE_ROM
select CHROMEOS
select CHROMEOS_RAMOOPS_DYNAMIC select CHROMEOS_RAMOOPS_DYNAMIC
select CHROMEOS_VBNV_CMOS select CHROMEOS_VBNV_CMOS
select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC

1
src/mainboard/intel/kunimitsu/Kconfig
View File

@ -4,7 +4,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
def_bool y def_bool y
select BOARD_ROMSIZE_KB_16384 select BOARD_ROMSIZE_KB_16384
select CACHE_ROM select CACHE_ROM
select CHROMEOS
select CHROMEOS_RAMOOPS_DYNAMIC select CHROMEOS_RAMOOPS_DYNAMIC
select CHROMEOS_VBNV_CMOS select CHROMEOS_VBNV_CMOS
select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC

1
src/mainboard/intel/sklrvp/Kconfig
View File

@ -4,7 +4,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
def_bool y def_bool y
select BOARD_ROMSIZE_KB_16384 select BOARD_ROMSIZE_KB_16384
select CACHE_ROM select CACHE_ROM
select CHROMEOS
select CHROMEOS_RAMOOPS_DYNAMIC select CHROMEOS_RAMOOPS_DYNAMIC
select CHROMEOS_VBNV_CMOS select CHROMEOS_VBNV_CMOS
select HAVE_ACPI_RESUME select HAVE_ACPI_RESUME

1
src/mainboard/intel/strago/Kconfig
View File

@ -5,7 +5,6 @@ config BOARD_SPECIFIC_OPTIONS
select VGA_ROM_RUN if !PAYLOAD_SEABIOS select VGA_ROM_RUN if !PAYLOAD_SEABIOS
select ALWAYS_LOAD_OPROM if !PAYLOAD_SEABIOS select ALWAYS_LOAD_OPROM if !PAYLOAD_SEABIOS
select BOARD_ROMSIZE_KB_8192 select BOARD_ROMSIZE_KB_8192
select CHROMEOS
select CHROMEOS_VBNV_CMOS select CHROMEOS_VBNV_CMOS
select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC
select EC_GOOGLE_CHROMEEC_MEC select EC_GOOGLE_CHROMEEC_MEC