GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/guybrush: Remove the GPIO_SIGN_OF_LIFE code 

Guybrush is pretty definitely alive, so this can be removed, as the
TODO line said.

BUG=180721202
TEST=Build

Signed-off-by: Martin Roth <martinroth@chromium.org>
Change-Id: I14f89f3e6f780c2da2136a838950ef2bcebc4c3a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52740
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Martin Roth 2021-04-28 12:10:57 -06:00 committed by Felix Held
parent 2415d9b2fb
commit 433c82761b
2 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/mainboard/google/guybrush/Kconfig
View File

@ -96,11 +96,4 @@ config MAINBOARD_FAMILY
string string
default "Google_Guybrush" default "Google_Guybrush"
config GPIO_SIGN_OF_LIFE
def_bool n
help
Enable toggling GPIO 31 as a sign of life on Guybrush
TODO: Remove this option when board is booting
endif # BOARD_GOOGLE_BASEBOARD_GUYBRUSH endif # BOARD_GOOGLE_BASEBOARD_GUYBRUSH

12
src/mainboard/google/guybrush/bootblock.c
View File

@ -5,9 +5,6 @@
#include <baseboard/variants.h> #include <baseboard/variants.h>
#include <console/console.h> #include <console/console.h>
#include <device/pci_ops.h> #include <device/pci_ops.h>
#include <delay.h>
#include <gpio.h>
#include <soc/gpio.h>
#include <soc/pci_devs.h> #include <soc/pci_devs.h>
void bootblock_mainboard_early_init(void) void bootblock_mainboard_early_init(void)
@ -38,15 +35,6 @@ void bootblock_mainboard_early_init(void)
dword |= 3 << 10; dword |= 3 << 10;
pm_write32(0x74, dword); pm_write32(0x74, dword);
if (CONFIG(GPIO_SIGN_OF_LIFE)) {
for (int x = 0; x < 20; x++) {
gpio_set(GPIO_31, 1);
mdelay(10);
gpio_set(GPIO_31, 0);
mdelay(10);
}
}
if (variant_has_fpmcu()) if (variant_has_fpmcu())
variant_fpmcu_reset(); variant_fpmcu_reset();
} }