From 434928c3a48188f68d333f4d03a758742bef66bf Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 24 Oct 2023 17:06:18 -0500 Subject: [PATCH] mb/starlabs/*/Kconfig: Fix default power state after failure POWER_STATE_OFF_AFTER_FAILURE can't be directly selected since it's a choice, so instead set POWER_STATE_DEFAULT_ON_AFTER_FAILURE to n, as it's functionally equivalent. This fixes the warnings generated by the pre-commit hook Kconfig check. It is necessary to override and set default n in the mainboard Kconfig as it is set to default y in src/soc/intel/common/block/pmc/Kconfig. TEST=select starlabs/starbook_adl in menuconfig and verify the default power-on setting is S5/soft off. Change-Id: I3ce33517dcc0af693b8db8d1de2926117ad3c16b Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/78627 Reviewed-by: Sean Rhodes Tested-by: build bot (Jenkins) Reviewed-by: Felix Held Reviewed-by: Eric Lai --- src/mainboard/starlabs/lite/Kconfig | 4 ++-- src/mainboard/starlabs/starbook/Kconfig | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mainboard/starlabs/lite/Kconfig b/src/mainboard/starlabs/lite/Kconfig index ee1958eec6..64926d976f 100644 --- a/src/mainboard/starlabs/lite/Kconfig +++ b/src/mainboard/starlabs/lite/Kconfig @@ -71,8 +71,8 @@ config MAINBOARD_SMBIOS_PRODUCT_NAME string default "Lite" -config POWER_STATE_OFF_AFTER_FAILURE - default y +config POWER_STATE_DEFAULT_ON_AFTER_FAILURE + default n config TRACKPAD_INTERRUPT hex diff --git a/src/mainboard/starlabs/starbook/Kconfig b/src/mainboard/starlabs/starbook/Kconfig index 4cb04c3b3d..4d0ebe41ff 100644 --- a/src/mainboard/starlabs/starbook/Kconfig +++ b/src/mainboard/starlabs/starbook/Kconfig @@ -159,8 +159,8 @@ config ME_BIN_PATH default "3rdparty/blobs/mainboard/\$(MAINBOARDDIR)/\$(CONFIG_VARIANT_DIR)/intel_me.bin" -config POWER_STATE_OFF_AFTER_FAILURE - default y +config POWER_STATE_DEFAULT_ON_AFTER_FAILURE + default n config EDK2_BOOTSPLASH_FILE string