soc/intel/skylake: lockdown: lock global reset

There are four chipsets selecting PMC_GLOBAL_RESET_ENABLE_LOCK but only
one (apollolake) is actually calling the code. Add the missing call.

Also fix the register offset in a comment in reset code.

Tested successfully on X11SSM-F by reading ETR3.

Change-Id: If190c3c66889ede105d958b423b38ebdcb698332
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36573
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Michael Niewöhner 2019-09-17 18:48:00 +02:00 committed by Patrick Georgi
parent 8370f6b79c
commit 43d2527203
2 changed files with 5 additions and 1 deletions

View File

@ -16,6 +16,7 @@
#include <device/mmio.h>
#include <intelblocks/cfg.h>
#include <intelblocks/lpc_lib.h>
#include <intelblocks/pmclib.h>
#include <intelpch/lockdown.h>
#include <soc/pm.h>
@ -38,6 +39,9 @@ static void pmc_lockdown_config(void)
pmsyncreg = read32(pmcbase + PMSYNC_TPR_CFG);
pmsyncreg |= PMSYNC_LOCK;
write32(pmcbase + PMSYNC_TPR_CFG, pmsyncreg);
/* Make sure payload/OS can't trigger global reset */
pmc_global_reset_disable_and_lock();
}
void soc_lockdown_config(int chipset_lockdown)

View File

@ -26,7 +26,7 @@ static void do_force_global_reset(void)
/*
* BIOS should ensure it does a global reset
* to reset both host and Intel ME by setting
* PCH PMC [B0:D31:F2 register offset 0x1048 bit 20]
* PCH PMC [B0:D31:F2 register offset 0xAC bit 20]
*/
pmc_global_reset_enable(true);