GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libpayload (EHCI): correctly align PORTSC 

Two structures in the USB EHCI stack were pointing
to hardware but not marked attribute((packed)) hence
leaving it to GCC to correctly align the data structures.

Next, the number of reserved bytes in hc_op_t was wrong
(but implicitly aligned to the correct values on x86)

It seems this worked fine on x86, but on ARM it was doing
the wrong thing.

Signed-off-by: Stefan Reinauer <reinauer@google.com>

Change-Id: I94bed4850ded7d3f7bbc7ff3079c103c6054c22d
Reviewed-on: https://gerrit.chromium.org/gerrit/55555
Commit-Queue: Stefan Reinauer <reinauer@google.com>
Reviewed-by: Stefan Reinauer <reinauer@google.com>
Tested-by: Stefan Reinauer <reinauer@google.com>
Reviewed-on: http://review.coreboot.org/4174
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Stefan Reinauer 2013-05-17 11:56:09 -07:00 committed by Stefan Reinauer
parent ed095ca39a
commit 441a4baf87
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
payloads/libpayload/drivers/usb/ehci_private.h
View File

@ -78,10 +78,10 @@ typedef volatile struct {
u32 ctrldssegment; u32 ctrldssegment;
u32 periodiclistbase; u32 periodiclistbase;
u32 asynclistaddr; u32 asynclistaddr;
u8 res1[0x3f-0x1c]; u8 res1[0x40-0x1c];
u32 configflag; u32 configflag;
portsc_t portsc[0]; portsc_t portsc[0];
} hc_op_t; } __attribute__ ((packed)) hc_op_t;
typedef volatile struct { typedef volatile struct {
#define QTD_TERMINATE 1 #define QTD_TERMINATE 1
@ -130,7 +130,7 @@ typedef volatile struct {
#define QH_PIPE_MULTIPLIER_SHIFT 30 #define QH_PIPE_MULTIPLIER_SHIFT 30
volatile u32 current_td_ptr; volatile u32 current_td_ptr;
volatile qtd_t td; volatile qtd_t td;
} ehci_qh_t; } __attribute__ ((packed)) ehci_qh_t;
typedef struct ehci { typedef struct ehci {
hc_cap_t *capabilities; hc_cap_t *capabilities;