GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cavium/bdk: Fix coverity and remove hardcoded DRAM speed 

* Fix CID1393963 (Uninitialized variables)
* Comment in working code
* Remove workaround to limit DDR speed

Change-Id: I96289da43c1018c2fdf9d013ce7f21d7511ba595
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/27452
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Patrick Rudolph 2018-07-12 13:07:04 +02:00 committed by Patrick Rudolph
parent 2531865f13
commit 4461613119
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/cavium/cn8100_sff_evb/bdk_devicetree.c
View File

@ -90,7 +90,6 @@ const struct bdk_devicetree_key_value devtree[] = {
{"MULTI-NODE", "0"},
{"QLM-AUTO-CONFIG", "0"},
{"QLM-DIP-AUTO-CONFIG", "1"},
{"DDR-SPEED.N0", "1333"},
{"DDR-CONFIG-SPD-ADDR.DIMM0.LMC0", "0x1050"},
{"USB-PWR-GPIO.N0.PORT0", "12"},
{"USB-PWR-GPIO-POLARITY.N0.PORT0", "0"},

8
src/vendorcode/cavium/bdk/libdram/dram-spd.c
View File

@ -549,15 +549,17 @@ dram_get_default_spd_speed(bdk_node_t node, const ddr_configuration_t *ddr_confi
int dimm_speed[8], dimm_count = 0;
int dimms_per_lmc = 0;
memset (dimm_speed, 0, sizeof(dimm_speed));
for (lmc = 0; lmc < 4; lmc++) {
for (dimm = 0; dimm < DDR_CFG_T_MAX_DIMMS; dimm++) {
const dimm_config_t *dimm_config = &ddr_config[lmc].dimm_config_table[dimm];
if (/*dimm_config->spd_addr ||*/ dimm_config->spd_ptr)
if (dimm_config->spd_addr || dimm_config->spd_ptr)
{
speed = (ddr_type == DDR4_DRAM)
? get_ddr4_spd_speed(node, dimm_config)
: get_ddr3_spd_speed(node, dimm_config);
//printf("N%d.LMC%d.DIMM%d: SPD speed %d\n", node, lmc, dimm, speed);
printf("N%d.LMC%d.DIMM%d: SPD speed %d\n", node, lmc, dimm, speed);
dimm_speed[dimm_count] = speed;
dimm_count++;
if (lmc == 0)
@ -596,6 +598,6 @@ dram_get_default_spd_speed(bdk_node_t node, const ddr_configuration_t *ddr_confi
ret_speed = mts_to_hertz(speed);
finish_up:
//printf("N%d: Returning default SPD speed %d\n", node, ret_speed);
printf("N%d: Returning default SPD speed %d\n", node, ret_speed);
return ret_speed;
}