GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/amd/mct_ddr3: Fix odd rank data corruption 

The odd rank of each DIMM could experience data corruption due to
incorrect DQS training.  Fix the DQS training algorithm by executing
the relevant portions of the training algorithm on the odd ranks.

Change-Id: Ibc51f5052d5189e45b3d9aa98ca8febbfe13f178
Signed-off-by: Timothy Pearson <tpearson@raptorengineeringinc.com>
Reviewed-on: https://review.coreboot.org/12058
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
This commit is contained in:
Timothy Pearson 2015-08-27 13:19:34 -05:00 committed by Martin Roth
parent df499b53c3
commit 4502df12aa
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/northbridge/amd/amdmct/mct_ddr3/mctdqs_d.c
View File

@ -1320,9 +1320,9 @@ static uint8_t TrainDQSRdWrPos_D_Fam15(struct MCTStatStruc *pMCTstat,
Receiver = receiver_start; Receiver = receiver_start;
/* There are four receiver pairs, loosely associated with chipselects. /* There are four receiver pairs, loosely associated with chipselects.
* This is essentially looping over each DIMM. * This is essentially looping over each rank within each DIMM.
*/ */
for (; Receiver < receiver_end; Receiver += 2) { for (; Receiver < receiver_end; Receiver++) {
dimm = (Receiver >> 1); dimm = (Receiver >> 1);
if ((Receiver & 0x1) == 0) { if ((Receiver & 0x1) == 0) {
/* Even rank of DIMM */ /* Even rank of DIMM */
@ -1336,10 +1336,16 @@ static uint8_t TrainDQSRdWrPos_D_Fam15(struct MCTStatStruc *pMCTstat,
continue; continue;
} }
#if DQS_TRAIN_DEBUG > 0
printk(BIOS_DEBUG, "TrainDQSRdWrPos: Training DQS read/write position for receiver %d (DIMM %d)\n", Receiver, dimm);
#endif
/* Initialize variables */ /* Initialize variables */
for (lane = lane_start; lane < lane_end; lane++) { for (lane = lane_start; lane < lane_end; lane++) {
passing_dqs_delay_found[lane] = 0; passing_dqs_delay_found[lane] = 0;
} }
if ((Receiver & 0x1) == 0) {
/* Even rank of DIMM */
memset(dqs_results_array, 0, sizeof(dqs_results_array)); memset(dqs_results_array, 0, sizeof(dqs_results_array));
/* Read initial read / write DQS delays */ /* Read initial read / write DQS delays */
@ -1348,6 +1354,9 @@ static uint8_t TrainDQSRdWrPos_D_Fam15(struct MCTStatStruc *pMCTstat,
/* Read current settings of other (previously trained) lanes */ /* Read current settings of other (previously trained) lanes */
read_dqs_write_data_timing_registers(initial_write_data_timing, dev, dct, dimm, index_reg); read_dqs_write_data_timing_registers(initial_write_data_timing, dev, dct, dimm, index_reg);
}
/* Initialize iterators */
memcpy(current_write_data_delay, initial_write_data_timing, sizeof(current_write_data_delay)); memcpy(current_write_data_delay, initial_write_data_timing, sizeof(current_write_data_delay));
for (lane = lane_start; lane < lane_end; lane++) { for (lane = lane_start; lane < lane_end; lane++) {