GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/x86: Fix control flow UNREACHABLE issue 

Coverity detects the control flow UNREACHABLE issue for the printk
usage. This change adds rc to keep the smm_module_setup_stub function
call and returns rc after printk usage.

Found-by: Coverity CID 1452602
TEST=None

Signed-off-by: John Zhao <john.zhao@intel.com>
Change-Id: Ie3b90a8197c3b84c5a1dbca8a9ef566bef35c9ab
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52574
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
John Zhao 2021-04-21 10:13:17 -07:00 committed by Felix Held
parent 8122b3f612
commit 457c661f62
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cpu/x86/smm/smm_module_loader.c
View File

@ -458,9 +458,9 @@ int smm_setup_relocation_handler(void * const perm_smram, struct smm_loader_par
if (params->num_concurrent_stacks == 0) if (params->num_concurrent_stacks == 0)
params->num_concurrent_stacks = CONFIG_MAX_CPUS; params->num_concurrent_stacks = CONFIG_MAX_CPUS;
printk(BIOS_SPEW, "%s: exit\n", __func__);
return smm_module_setup_stub(smram, SMM_DEFAULT_SIZE, return smm_module_setup_stub(smram, SMM_DEFAULT_SIZE,
params, fxsave_area_relocation, perm_smram); params, fxsave_area_relocation, perm_smram);
printk(BIOS_SPEW, "%s: exit\n", __func__);
} }
/* /*