GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/device.h: Fix outdated comment 

LAPIC devices in devicetree is not possible any longer since commit
3eba665 "util/sconfig: Remove lapic devices from devicetree parsers".

TEST=intel/archercity CRB

Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Change-Id: I02192c9a11c35d9625837a8a9f3ba798ff0ae611
Reviewed-on: https://review.coreboot.org/c/coreboot/+/78329
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Shuo Liu <shuo.liu@intel.com>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
This commit is contained in:
Arthur Heymans 2023-08-25 11:50:25 +02:00 committed by Lean Sheng Tan
parent 20a9533946
commit 45be5b3b4e
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/include/device/device.h
View File

@ -229,14 +229,7 @@ struct device *add_cpu_device(struct bus *cpu_bus, unsigned int apic_id,
void mp_init_cpus(DEVTREE_CONST struct bus *cpu_bus);
static inline void mp_cpu_bus_init(struct device *dev)
{
/*
* When no LAPIC device is specified in the devicetree inside the CPU cluster device,
* neither a LAPIC device nor the link/bus between the CPU cluster and the LAPIC device
* will be present in the static device tree and the link_list struct element of the
* CPU cluster device will be NULL. In this case add one link, so that the
* alloc_find_dev calls in init_bsp and allocate_cpu_devices will be able to add a
* LAPIC device for the BSP and the APs on this link/bus.
*/
/* Make sure the cpu cluster has a downstream bus for LAPICs to be allocated. */
if (!dev->link_list)
add_more_links(dev, 1);