From 45d5f8f163898f943679129416b5c0d93c61c407 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sun, 19 Jul 2020 01:38:28 +0200 Subject: [PATCH] sio/nuvoton/common/early_serial.c: Guard serial enable If CONSOLE_SERIAL is not set, do not reconfigure the UART LDN. Otherwise, SerialICE stops working when the UART LDN is disabled. Change-Id: Ie3113e6b7b830dfdddc4d7709f00719f29e094bf Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/43582 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Nico Huber --- src/superio/nuvoton/common/early_serial.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/superio/nuvoton/common/early_serial.c b/src/superio/nuvoton/common/early_serial.c index f4938f0edc..22d882ef1a 100644 --- a/src/superio/nuvoton/common/early_serial.c +++ b/src/superio/nuvoton/common/early_serial.c @@ -47,6 +47,9 @@ void nuvoton_pnp_exit_conf_state(pnp_devfn_t dev) /* Bring up early serial debugging output before the RAM is initialized. */ void nuvoton_enable_serial(pnp_devfn_t dev, u16 iobase) { + if (!CONFIG(CONSOLE_SERIAL)) + return; + nuvoton_pnp_enter_conf_state(dev); if (CONFIG(SUPERIO_NUVOTON_NCT5539D_COM_A))