From 4694b32511f2b0ecf732d640e0842fd17c44a660 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 8 May 2023 19:44:07 +0200 Subject: [PATCH] mb/google/skyrim: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: I097d50a7af7c8ea48369806e8bb73734a8e84470 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/75024 Reviewed-by: Martin L Roth Tested-by: build bot (Jenkins) --- src/mainboard/google/skyrim/Kconfig | 22 ++++++++++++++++++++++ src/mainboard/google/skyrim/Kconfig.name | 12 ------------ 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index 437fe89d5f..59f6c67872 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -3,6 +3,28 @@ config BOARD_GOOGLE_BASEBOARD_SKYRIM def_bool n +config BOARD_GOOGLE_SKYRIM + select BOARD_GOOGLE_BASEBOARD_SKYRIM + select SOC_AMD_COMMON_BLOCK_ACPI_DPTC + +config BOARD_GOOGLE_WINTERHOLD + select BOARD_GOOGLE_BASEBOARD_SKYRIM + select SOC_AMD_COMMON_BLOCK_ACPI_DPTC + select FEATURE_DYNAMIC_DPTC + +config BOARD_GOOGLE_FROSTFLOW + select BOARD_GOOGLE_BASEBOARD_SKYRIM + select DRIVERS_GENESYSLOGIC_GL9755 + select FEATURE_TABLET_MODE_DPTC + select SOC_AMD_COMMON_BLOCK_ACPI_DPTC + +config BOARD_GOOGLE_CRYSTALDRIFT + select BOARD_GOOGLE_BASEBOARD_SKYRIM + +config BOARD_GOOGLE_MARKARTH + select BOARD_GOOGLE_BASEBOARD_SKYRIM + select SOC_AMD_COMMON_BLOCK_ACPI_DPTC + if BOARD_GOOGLE_BASEBOARD_SKYRIM config BOARD_SPECIFIC_OPTIONS diff --git a/src/mainboard/google/skyrim/Kconfig.name b/src/mainboard/google/skyrim/Kconfig.name index 7e458770e5..a68ecb061b 100644 --- a/src/mainboard/google/skyrim/Kconfig.name +++ b/src/mainboard/google/skyrim/Kconfig.name @@ -2,27 +2,15 @@ comment "Skyrim" config BOARD_GOOGLE_SKYRIM bool "-> Skyrim" - select BOARD_GOOGLE_BASEBOARD_SKYRIM - select SOC_AMD_COMMON_BLOCK_ACPI_DPTC config BOARD_GOOGLE_WINTERHOLD bool "-> Winterhold" - select BOARD_GOOGLE_BASEBOARD_SKYRIM - select SOC_AMD_COMMON_BLOCK_ACPI_DPTC - select FEATURE_DYNAMIC_DPTC config BOARD_GOOGLE_FROSTFLOW bool "-> Frostflow" - select BOARD_GOOGLE_BASEBOARD_SKYRIM - select DRIVERS_GENESYSLOGIC_GL9755 - select FEATURE_TABLET_MODE_DPTC - select SOC_AMD_COMMON_BLOCK_ACPI_DPTC config BOARD_GOOGLE_CRYSTALDRIFT bool "-> Crystaldrift" - select BOARD_GOOGLE_BASEBOARD_SKYRIM config BOARD_GOOGLE_MARKARTH bool "-> Markarth" - select BOARD_GOOGLE_BASEBOARD_SKYRIM - select SOC_AMD_COMMON_BLOCK_ACPI_DPTC