GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/skyrim: Re-enable USE_SELECTIVE_GOP_INIT for Skyrim 

This reverts commit dc7cc5bc6e ("mb/google/skyrim: Disable
USE_SELECTIVE_GOP_INIT") but limits the default enablement to Skyrim
variant only, to allow for continued testing.

BUG=b:271850970
BRANCH=skyrim
TEST=build/boot ChromeOS R117+ on google/skyrim, verify no display init
failures with feature enabled on cold/warm boots or S0i3 resume.

Change-Id: I21c70111a5f407a7e8dd1ad1f2c2759ddb91893e
Signed-off-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/77964
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
This commit is contained in:
Matt DeVillier 2023-09-15 12:48:35 -05:00 committed by Felix Held
parent a63a56d572
commit 4712f5d560
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/skyrim/Kconfig
View File

@ -39,6 +39,7 @@ config BOARD_SPECIFIC_OPTIONS
select SOC_AMD_MENDOCINO
select SOC_AMD_COMMON_BLOCK_I2C3_TPM_SHARED_WITH_PSP
select SOC_AMD_COMMON_BLOCK_USE_ESPI
select SOC_AMD_GFX_CACHE_VBIOS_IN_FMAP if CHROMEOS && RUN_FSP_GOP
select SYSTEM_TYPE_LAPTOP
select TPM_GOOGLE_TI50
select PCIEXP_ASPM
@ -136,6 +137,9 @@ config USE_VARIANT_DXIO_DESCRIPTOR
Enable this to allow a variant to override the dxio descriptor values
in port_descriptors.c
config USE_SELECTIVE_GOP_INIT
default y if CHROMEOS && RUN_FSP_GOP && BOARD_GOOGLE_SKYRIM
config VBOOT
select EC_GOOGLE_CHROMEEC_SWITCHES
select VBOOT_LID_SWITCH