From 473e0c35fe2ecd70ed791936e65d8924f16e528c Mon Sep 17 00:00:00 2001 From: Benson Leung Date: Tue, 22 Mar 2016 13:37:51 -0700 Subject: [PATCH] google/chell: Adjust nuvoton 8825 button thresholds again. Changing these thresholds again for new tuning in March of 2016. Something's changed in the latest firmware to cause all values previously read on Chell to float down. Set "nuvoton,sar-threshold" property to thresholds based on tuning with the Android Wired Headphone Compatibility Kit and Chell DVT. Signed-off-by: Benson Leung BUG=chrome-os-partner:49333 BRANCH=none TEST=Run evtest, selecting the input event for sklnau8825adi Using the Nominal headphones from the kit, check that the buttons for "KEY_VOLUMEDOWN", "KEY_VOLUMEUP", "KEY_MEDIA", and code 582 (?) (should be voice search, but evtest doesn't understand) All of these buttons should work properly. Change-Id: Ie5ff1d35599d2cca5ce76467ecd7ec3ecab42d8b Signed-off-by: Patrick Georgi Original-Commit-Id: 1d13e967addb5cd31e6196e32541cda97ae00257 Original-Change-Id: I11de7a0853a3598f3834e8bae3140b9942cbd0b0 Original-Reviewed-on: https://chromium-review.googlesource.com/334402 Original-Commit-Ready: Benson Leung Original-Tested-by: Benson Leung Original-Reviewed-by: Duncan Laurie Reviewed-on: https://review.coreboot.org/14233 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Martin Roth --- src/mainboard/google/chell/acpi/mainboard.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/google/chell/acpi/mainboard.asl b/src/mainboard/google/chell/acpi/mainboard.asl index a7c7bfe55f..67de19da96 100644 --- a/src/mainboard/google/chell/acpi/mainboard.asl +++ b/src/mainboard/google/chell/acpi/mainboard.asl @@ -172,7 +172,7 @@ Scope (\_SB.PCI0.I2C4) * Compatibility Kit and a Chell EVT */ Package () {"nuvoton,sar-threshold", - Package () {0x20, 0x32, 0x50, 0x70}}, + Package () {0x0c, 0x1c, 0x38, 0x60}}, Package () {"nuvoton,sar-hysteresis", 1}, /* VDDA for button impedance measurement */ Package () {"nuvoton,sar-voltage", 0},