GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/{cnl, icl}: Remove unnecessary __SIMPLE_DEVICE__ check 

soc_pch_pirq_init() function is only getting compiled for RAMSTAGE
hence remove unused __SIMPLE_DEVICE__ check.

Change-Id: I7f0ca62170f0af12a251c8c97155de8433a31854
Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Reviewed-on: https://review.coreboot.org/29643
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Subrata Banik 2018-11-17 15:17:38 +05:30 committed by Nico Huber
parent d4b89091d2
commit 47df66d765
2 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/soc/intel/cannonlake/lpc.c
View File

@ -145,6 +145,7 @@ static void pch_enable_ioapic(const struct device *dev)
void soc_pch_pirq_init(const struct device *dev) void soc_pch_pirq_init(const struct device *dev)
{ {
struct device *irq_dev;
uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG]; uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG];
pch_interrupt_routing[0] = PCH_IRQ11; pch_interrupt_routing[0] = PCH_IRQ11;
@ -157,11 +158,7 @@ void soc_pch_pirq_init(const struct device *dev)
pch_interrupt_routing[7] = PCH_IRQ11; pch_interrupt_routing[7] = PCH_IRQ11;
itss_irq_init(pch_interrupt_routing); itss_irq_init(pch_interrupt_routing);
#if defined(__SIMPLE_DEVICE__)
pci_devfn_t irq_dev;
#else
struct device *irq_dev;
#endif
for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) {
u8 int_pin = 0, int_line = 0; u8 int_pin = 0, int_line = 0;

7
src/soc/intel/icelake/lpc.c
View File

@ -144,6 +144,7 @@ static void pch_enable_ioapic(const struct device *dev)
void soc_pch_pirq_init(const struct device *dev) void soc_pch_pirq_init(const struct device *dev)
{ {
struct device *irq_dev;
uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG]; uint8_t pch_interrupt_routing[MAX_PXRC_CONFIG];
pch_interrupt_routing[0] = PCH_IRQ11; pch_interrupt_routing[0] = PCH_IRQ11;
@ -156,11 +157,7 @@ void soc_pch_pirq_init(const struct device *dev)
pch_interrupt_routing[7] = PCH_IRQ11; pch_interrupt_routing[7] = PCH_IRQ11;
itss_irq_init(pch_interrupt_routing); itss_irq_init(pch_interrupt_routing);
#if defined(__SIMPLE_DEVICE__)
pci_devfn_t irq_dev;
#else
struct device *irq_dev;
#endif
for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) { for (irq_dev = all_devices; irq_dev; irq_dev = irq_dev->next) {
u8 int_pin = 0, int_line = 0; u8 int_pin = 0, int_line = 0;