GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/zork: Drop mainboard_ec_init() from romstage 

mainboard_ec_init() does nothing in any stage other than ramstage. So,
this change drops the call to mainboard_ec_init() from
romstage.c. Additionally, it also drops ec.c from romstage and
verstage.

Change-Id: Iae0be4d678b0780cf532000a6c0fff1bce333c0e
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43117
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Furquan Shaikh 2020-07-02 18:41:34 -07:00
parent fa78dd16bf
commit 484f107ac4
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/zork/Makefile.inc
View File

@ -3,7 +3,6 @@
bootblock-y += bootblock.c bootblock-y += bootblock.c
romstage-y += chromeos.c romstage-y += chromeos.c
romstage-y += ec.c
romstage-y += sku_id.c romstage-y += sku_id.c
ramstage-y += chromeos.c ramstage-y += chromeos.c
@ -14,7 +13,6 @@ ifeq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),y)
verstage-y += verstage.c verstage-y += verstage.c
else else
verstage-y += chromeos.c verstage-y += chromeos.c
verstage-y += ec.c
endif endif
smm-y += smihandler.c smm-y += smihandler.c

5
src/mainboard/google/zork/romstage.c
View File

@ -1,11 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <baseboard/variants.h> #include <baseboard/variants.h>
#include <ec/ec.h>
#include <ec/google/chromeec/ec.h>
#include <soc/gpio.h> #include <soc/gpio.h>
#include <soc/romstage.h> #include <soc/romstage.h>
#include <variant/ec.h>
#include <console/console.h> #include <console/console.h>
void mainboard_romstage_entry_s3(int s3_resume) void mainboard_romstage_entry_s3(int s3_resume)
@ -16,6 +13,4 @@ void mainboard_romstage_entry_s3(int s3_resume)
gpios = variant_romstage_gpio_table(&num_gpios); gpios = variant_romstage_gpio_table(&num_gpios);
program_gpios(gpios, num_gpios); program_gpios(gpios, num_gpios);
variant_pcie_power_reset_configure(); variant_pcie_power_reset_configure();
mainboard_ec_init();
} }