GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/poppy/variant/nocturne: Configure GPP_E1 for WLAN_WAKE_L 

The GPP_E1 gpio was incorrectly being defined as a no-connect.
Configure GPP_E1 for the WLAN_WAKE_L signal as per the schematic.

BUG=b:119508897
TEST=Build and flash nocturne, boot nocturne and
 1) Verify nocturne can successfully suspend/resume from S3 and S0ix.
 2) Verify wake from wlan wakes device from S3 and S0ix.
    To do so,
    a) as root, execute "iw phy phy0 wowlan enable disconnect" on DUT
    b) connect DUT to mobile hotspot
    c) sleep device via "powerd_dbus_suspend"
    d) turn off hotspot, verify DUT wakes from S0ix
    e) enable hotspot again
    f) connect DUT to hotspot
    g) sleep DUT via "sudo echo mem > /sys/power/state"
    h) turn off hotspot, verify DUT wakes from S3

Change-Id: I4efb4f6d601e172ae4807901e3bd4c9954319f80
Signed-off-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-on: https://review.coreboot.org/29630
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Nick Vaccaro 2018-11-13 13:39:48 -08:00 committed by Patrick Georgi
parent 1e8c9ad54f
commit 49abfca717
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/poppy/variants/nocturne/gpio.c
View File

@ -212,8 +212,8 @@ static const struct pad_config gpio_table[] = {
/* E0 : SATAXPCI0 ==> H1_PCH_INT_ODL */ /* E0 : SATAXPCI0 ==> H1_PCH_INT_ODL */
PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST), PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST),
/* E1 : SATAXPCIE1 ==> NC */ /* E1 : SATAXPCIE1 ==> WLAN_WAKE_L */
PAD_CFG_NC(GPP_E1), PAD_CFG_GPI_ACPI_SCI(GPP_E1, NONE, DEEP, INVERT),
/* E2 : SATAXPCIE2 ==> BT_DISABLE_L */ /* E2 : SATAXPCIE2 ==> BT_DISABLE_L */
PAD_CFG_GPO(GPP_E2, 1, DEEP), PAD_CFG_GPO(GPP_E2, 1, DEEP),
/* E3 : CPU_GP0 ==> NC */ /* E3 : CPU_GP0 ==> NC */