GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/gitconfig: Make checkpatch non fatal in pre-commit hook 

We don't block commits for failing checkpatch in gerrit, and we
shouldn't block them here.  This allows checkpatch to still run, so
users can see the issues, but won't prevent the commit.

Adds a delay if checkpatch fails so that the issues can be seen.

Change-Id: Ibd4e8bb74e0b02825dcdf16e233a061c4bb43f50
Signed-off-by: Martin Roth <martin@coreboot.org>
Reviewed-on: https://review.coreboot.org/27534
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This commit is contained in:
Martin Roth 2018-07-18 09:40:29 -06:00 committed by Martin Roth
parent 31fb846c59
commit 4a6477ed64
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
util/gitconfig/pre-commit
View File

@ -24,5 +24,6 @@ PATCHDIFF=$(git diff --cached --src-prefix=a/ --dst-prefix=b/)
if printf "%s\n" "$PATCHDIFF" | grep -q "@@"; then if printf "%s\n" "$PATCHDIFF" | grep -q "@@"; then
echo echo
echo "Running checkpatch" echo "Running checkpatch"
printf "%s\n" "$PATCHDIFF" | util/lint/lint-007-checkpatch diff printf "%s\n" "$PATCHDIFF" | util/lint/lint-007-checkpatch diff \
|| (echo "Please consider fixing these issues." ;sleep 5) ; true
fi fi