GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a default path for vbt.bin 

FSP_GOP needs a vbt.bin to work but before this patch it was able to
build with the default configuration which was an empty path for
vbt.bin.

To make Jenkins happy don't select FSP_GOP by default, at least until
all boards have the proper vbt blobs in the blobs repo.

Change-Id: Ibc36d6d4dd1a56c53819b169e6f4799ce3c23e03
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/23290
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Arthur Heymans 2018-01-16 17:22:20 +01:00 committed by Matt DeVillier
parent 823dbde2ab
commit 4ad1f7d67e
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/device/Kconfig
View File

@ -82,15 +82,6 @@ config MAINBOARD_USE_LIBGFXINIT
Use the SPARK library `libgfxinit` for the native graphics Use the SPARK library `libgfxinit` for the native graphics
initialization. This requires an Ada toolchain. initialization. This requires an Ada toolchain.
config RUN_FSP_GOP
bool "Run a GOP driver"
depends on HAVE_FSP_GOP
select HAVE_LINEAR_FRAMEBUFFER
help
Some platforms (e.g. Intel Braswell and Skylake/Kaby Lake) support
to run a GOP blob. This option enables graphics initialization with
such a blob.
# TODO: Explain differences (if any) for onboard cards. # TODO: Explain differences (if any) for onboard cards.
config VGA_ROM_RUN config VGA_ROM_RUN
bool "Run VGA Option ROMs" bool "Run VGA Option ROMs"
@ -105,6 +96,15 @@ config VGA_ROM_RUN
more complete BIOS interrupt services available than coreboot, more complete BIOS interrupt services available than coreboot,
which some option ROMs require in order to function correctly. which some option ROMs require in order to function correctly.
config RUN_FSP_GOP
bool "Run a GOP driver"
depends on HAVE_FSP_GOP
select HAVE_LINEAR_FRAMEBUFFER
help
Some platforms (e.g. Intel Braswell and Skylake/Kaby Lake) support
to run a GOP blob. This option enables graphics initialization with
such a blob.
config NO_GFX_INIT config NO_GFX_INIT
bool "None" bool "None"
depends on !MAINBOARD_FORCE_NATIVE_VGA_INIT depends on !MAINBOARD_FORCE_NATIVE_VGA_INIT
@ -609,6 +609,7 @@ config INTEL_GMA_ADD_VBT_DATA_FILE
config INTEL_GMA_VBT_FILE config INTEL_GMA_VBT_FILE
string "VBT binary path and filename" string "VBT binary path and filename"
depends on INTEL_GMA_ADD_VBT_DATA_FILE depends on INTEL_GMA_ADD_VBT_DATA_FILE
default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/vbt.bin"
help help
The path and filename of the VBT binary. The path and filename of the VBT binary.