GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel: Use 'enum cb_err' instead of bool 

The patch uses 'enum cb_err' values as return values for
cse_get_bp_info() function.

TEST=Build the code for Gimble

Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Change-Id: I900e40b699de344f497e61d974bca3fee7f6ecbf
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71821
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Sridhar Siricilla 2023-01-10 14:43:18 +05:30
parent a088887acf
commit 4b6e8ca3a1
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/soc/intel/common/block/cse/cse_lite.c
View File

@ -249,7 +249,7 @@ static bool cse_is_bp_cmd_info_possible(void)
return false; return false;
} }
static bool cse_get_bp_info(struct get_bp_info_rsp *bp_info_rsp) static enum cb_err cse_get_bp_info(struct get_bp_info_rsp *bp_info_rsp)
{ {
struct get_bp_info_req { struct get_bp_info_req {
struct mkhi_hdr hdr; struct mkhi_hdr hdr;
@ -264,7 +264,7 @@ static bool cse_get_bp_info(struct get_bp_info_rsp *bp_info_rsp)
if (!cse_is_bp_cmd_info_possible()) { if (!cse_is_bp_cmd_info_possible()) {
printk(BIOS_ERR, "cse_lite: CSE does not meet prerequisites\n"); printk(BIOS_ERR, "cse_lite: CSE does not meet prerequisites\n");
return false; return CB_ERR;
} }
size_t resp_size = sizeof(struct get_bp_info_rsp); size_t resp_size = sizeof(struct get_bp_info_rsp);
@ -272,18 +272,18 @@ static bool cse_get_bp_info(struct get_bp_info_rsp *bp_info_rsp)
if (heci_send_receive(&info_req, sizeof(info_req), bp_info_rsp, &resp_size, if (heci_send_receive(&info_req, sizeof(info_req), bp_info_rsp, &resp_size,
HECI_MKHI_ADDR)) { HECI_MKHI_ADDR)) {
printk(BIOS_ERR, "cse_lite: Could not get partition info\n"); printk(BIOS_ERR, "cse_lite: Could not get partition info\n");
return false; return CB_ERR;
} }
if (bp_info_rsp->hdr.result) { if (bp_info_rsp->hdr.result) {
printk(BIOS_ERR, "cse_lite: Get partition info resp failed: %d\n", printk(BIOS_ERR, "cse_lite: Get partition info resp failed: %d\n",
bp_info_rsp->hdr.result); bp_info_rsp->hdr.result);
return false; return CB_ERR;
} }
cse_print_boot_partition_info(&bp_info_rsp->bp_info); cse_print_boot_partition_info(&bp_info_rsp->bp_info);
return true; return CB_SUCCESS;
} }
/* /*
* It sends HECI command to notify CSE about its next boot partition. When coreboot wants * It sends HECI command to notify CSE about its next boot partition. When coreboot wants
@ -1090,7 +1090,7 @@ void cse_fw_sync(void)
return; return;
} }
if (!cse_get_bp_info(&cse_bp_info)) { if (cse_get_bp_info(&cse_bp_info) != CB_SUCCESS) {
printk(BIOS_ERR, "cse_lite: Failed to get CSE boot partition info\n"); printk(BIOS_ERR, "cse_lite: Failed to get CSE boot partition info\n");
/* If system is in recovery mode, don't trigger recovery again */ /* If system is in recovery mode, don't trigger recovery again */