GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/apollolake: Configure FSP UPDs to allow coreboot to lockdown 

Configure FSP S UPDs to allow coreboot to handle the lockdown.

The main change here is setting `Write Protection Support` to 0,
as the default is Enabled, which shouldn't allow writes (even though
it seems to).

The UPDs are identical on APL and GLK, but all ones configured
in this patch have been there since their initial releases.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: I1f6e5344cab2af7aa6001b9ec0f07b043a9caa8a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67754
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Sean Rhodes 2022-09-21 08:52:42 +01:00 committed by Angel Pons
parent 96fa2377e2
commit 4b966b57ed
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/soc/intel/apollolake/chip.c
View File

@ -697,11 +697,13 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *silupd)
silconfig->SkipMpInit = !CONFIG(USE_INTEL_FSP_MP_INIT);
/* Disable setting of EISS bit in FSP. */
silconfig->SpiEiss = 0;
/* Disable FSP from locking access to the RTC NVRAM */
silconfig->RtcLock = 0;
/* coreboot handles the lockdown */
silconfig->LockDownGlobalSmi = 0;
silconfig->BiosLock = 0;
silconfig->BiosInterface = 0;
silconfig->WriteProtectionEnable[0] = 0;
silconfig->SpiEiss = 0;
silconfig->RtcLock = 0;
/* Enable Audio clk gate and power gate */
silconfig->HDAudioClkGate = cfg->hdaudio_clk_gate_enable;